fix(core): add additional checks in verifyUniqueWithinMutation for pruned mutations #9450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances mutation verification by skipping pruned entries, enriches error context in binary copying, and adds a regression test to prevent panics when unique predicates are conditionally pruned.
- Skip out-of-bounds or nil entries in
verifyUniqueWithinMutationto handle pruned mutations. - Include source and destination paths in the
copyBinaryerror message. - Add
TestWithConditionallyPrunedMutationsto verify no panic and correct UID assignments.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| edgraph/server.go | Added bounds checks and updated duplicate-value logic in verifyUniqueWithinMutation. |
| dgraphtest/image.go | Augmented copyBinary error wrap to include toPath and fromPath. |
| dgraph/cmd/alpha/run_test.go | Introduced a test to cover conditionally pruned mutations and ensure stability. |
Comments suppressed due to low confidence (1)
edgraph/server.go:2173
- [nitpick] Consider using
%qor%sverbs instead of%vwhen formatting strings to ensure proper quoting and improve readability, e.g.,"could not insert duplicate value %q for predicate %q".
pred1Value, pred1.Predicate)
|
|
672bca4 to
1003aa2
Compare
1003aa2 to
412b88b
Compare
… mutations are validated unique
Suggestion from github cp
412b88b to
dcf7fd9
Compare
harshil-goel
approved these changes
Aug 6, 2025
matthewmcneely
added a commit
that referenced
this pull request
Aug 6, 2025
…uned mutations (#9450) This PR adds additional checks in edgraph/server.go verifyUniqueWithinMutation for mutations that may have been conditionally pruned in `updateMutations` (called just before).
3 tasks
matthewmcneely
added a commit
that referenced
this pull request
Aug 7, 2025
…uned mutations (#9478) **Description** Cherry picked from main (original PR #9450) into release/v24.1 This PR adds additional checks in edgraph/server.go::verifyUniqueWithinMutation for mutations that may have been conditionally pruned in updateMutations (called just before). Also a basic test verifies not only the prevention of the panic but also assures unpruned mutations were applied. Note this is an improvement upon #9449 in that additional range and inner loop predicate checks were required (@gooohgb). **Checklist** - [x] Code compiles correctly and linting passes locally - [x] For all _code_ changes, an entry added to the `CHANGELOG.md` file describing and linking to this PR - [x] Tests added for new functionality, or regression tests for bug fixes added as applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional checks in edgraph/server.go::verifyUniqueWithinMutation for mutations that may have been conditionally pruned in
updateMutations(called just before).Also a basic test verifies not only the prevention of the panic but also assures unpruned mutations were applied. Note this is an improvement upon #9449 in that additional range and inner loop predicate checks were required (@gooohgb).
Assigning to @shivaji-kharse as the original author of this function.
Checklist
CHANGELOG.mdfile describing and linking tothis PR