Skip to content

fix(core): fix unmarshal protobuf when len val is 0 #9347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2025
Merged

fix(core): fix unmarshal protobuf when len val is 0 #9347

merged 3 commits into from
Mar 18, 2025

Conversation

harshil-goel
Copy link
Contributor

No description provided.

@harshil-goel harshil-goel requested a review from a team as a code owner March 18, 2025 05:18
@github-actions github-actions bot added area/schema Issues related to the schema language and capabilities. area/core internal mechanisms go Pull requests that update Go code labels Mar 18, 2025
mangalaman93
mangalaman93 requested changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@github-actions github-actions bot added the area/testing Testing related issues label Mar 18, 2025
mangalaman93
mangalaman93 previously approved these changes Mar 18, 2025
View reviewed changes
@mangalaman93 mangalaman93 enabled auto-merge (squash) March 18, 2025 08:13
@mangalaman93 mangalaman93 merged commit 7d11922 into main Mar 18, 2025
14 checks passed
@mangalaman93 mangalaman93 deleted the harshil-goel/fix-protobuf branch March 18, 2025 10:57
harshil-goel added a commit that referenced this pull request Mar 18, 2025
@harshil-goel
fix(core): fix unmarshal protobuf when len val is 0 (#9347)
8362946
harshil-goel added a commit that referenced this pull request Mar 18, 2025
@harshil-goel
fix(core): fix unmarshal protobuf when len val is 0 (#9347) (#9349)
84386ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees
No one assigned
Labels
area/core internal mechanisms area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil-goel @mangalaman93