Skip to content

remove stratum mining options and services #8802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 12, 2025

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jun 11, 2025

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

This PR just removes Stratum mining CLI, RPC methods, configuration, metrics category, and testing. Does not completely remove PoW.

Also removes eth_getWork and other related RPCs

Fixed Issue(s)

ref #8592

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 9 commits June 11, 2025 13:02
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…stratum-mining

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla closed this Jun 11, 2025
@macfarla
Copy link
Contributor Author

Tests (removed in this PR) for PoWSolver are specific for Stratum mining - they were all added here https://github.com/hyperledger/besu/pull/2576/files#diff-80e13a73e2a3ea828625d1ceae1634a0e1dd2ddee68bacf595e7f35168a7dd51

@macfarla macfarla reopened this Jun 11, 2025
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑🧹

@macfarla macfarla merged commit c82b329 into hyperledger:main Jun 12, 2025
48 checks passed
@macfarla macfarla deleted the rm-stratum-mining branch June 12, 2025 11:01
@macfarla macfarla added techdebt maintenance, cleanup, refactoring, documentation doc-change-required Indicates an issue or PR that requires doc to be updated labels Jun 13, 2025
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
techdebt maintenance, cleanup, refactoring, documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants