removes PoWAlgorithm and its references #8592
Conversation
Signed-off-by: jflo <justin+github@florentine.us>
| .blockHeaderValidatorBuilder( | ||
| feeMarket -> | ||
| MainnetBlockHeaderValidator.createPgaBlockHeaderValidator( | ||
| new EpochCalculator.Ecip1099EpochCalculator(), powHasher(PowAlgorithm.ETHASH))) | ||
| .ommerHeaderValidatorBuilder( | ||
| feeMarket -> | ||
| MainnetBlockHeaderValidator.createLegacyFeeMarketOmmerValidator( | ||
| new EpochCalculator.Ecip1099EpochCalculator(), powHasher(PowAlgorithm.ETHASH))) |
There was a problem hiding this comment.
does this break ETC support? it looks like we are no longer validating PoW header fields.
| if (isEthHash()) { | ||
| builder.put("ethash", getEthashConfigOptions().asMap()); | ||
| } |
There was a problem hiding this comment.
it seems like this will break external use cases that rely on fixed difficulty ethash chains.
| CommandLineUtils.checkOptionDependencies( | ||
| logger, | ||
| commandLine, | ||
| "--miner-enabled", | ||
| !isMiningEnabled, | ||
| asList( | ||
| "--miner-stratum-enabled", | ||
| "--Xminer-remote-sealers-limit", | ||
| "--Xminer-remote-sealers-hashrate-ttl")); |
There was a problem hiding this comment.
this isn't just PoW, this is clique and PoA right? miner has never been the right name, but IIRC PoA algorithms still need to use miner-enabled and this check I believe is still valid for sealer opts
yes, it would break ETC support. See this pr for more mining removal: https://github.com/hyperledger/besu/pull/8454/files |
|
This pr is stale because it has been open for 30 days with no activity. |
|
This pr was closed because it has been inactive for 14 days since being marked as stale. |
The first of a series of PRs to remove PoW from Besu.