feat(peerDAS): add max number of blob per transaction #8761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a per-transaction blob limit (max blobs per transaction) across scheduling, calculators, validation, JSON-RPC endpoints, and configuration parsing. It updates:
- The blob schedule model and JSON config to accept a new
maxPerTxfield, defaulting tomax. - Osaka/Cancun gas limit calculators and the transaction validator to enforce the new per-transaction blob gas cap.
- Tests and JSON-RPC logic to validate blob count against the new limit.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ethereum/core/src/main/java/.../OsakaTargetingGasLimitCalculator.java | Added maxBlobsPerTransaction parameter and transactionBlobGasLimitCap. |
| ethereum/core/src/main/java/.../MainnetBlobsValidator.java | Enforced per-transaction blob gas limit in validation. |
| ethereum/core/src/main/java/.../GasLimitCalculator.java | Added default transactionBlobGasLimitCap() method. |
| ethereum/api/src/.../AbstractEngineNewPayload.java | Added RPC-level blob count check against transactionBlobGasLimitCap. |
| config/src/main/java/.../BlobSchedule.java | Switched to static factory, added maxPerTransaction, and key parsing. |
| config/src/test/resources/mainnet_with_blob_schedule.json | Introduced maxPerTx fields in blob schedules. |
| config/src/main/java/.../BlobScheduleOptionsTest.java | Expanded tests for parsing maxPerTransaction. |
| ethereum/core/.../OsakaTargetingGasLimitCalculatorTest.java & related tests | Updated constructor calls and tests for new parameter. |
Comments suppressed due to low confidence (1)
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/OsakaTargetingGasLimitCalculator.java:59
- The method
getBlobGasPerBlob()does not exist onGasCalculator; usegasCalculator.blobGasCost(1)(or another appropriate call) to retrieve the per-blob gas cost, then multiply bymaxBlobsPerTransaction.
this.transactionBlobGasLimitCap = gasCalculator.getBlobGasPerBlob() * maxBlobsPerTransaction;
| "bpo5": { | ||
| "target": 51, | ||
| "max": 52, | ||
| "maxPerTx": 53, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
macfarla
reviewed
Jun 9, 2025
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/GasLimitCalculator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetBlobsValidator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetBlobsValidator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetBlobsValidator.java
Show resolved
Hide resolved
…r block Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo
approved these changes
Jun 9, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
|
cherry-picked commit from #8820 |
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implements ethereum/EIPs#9623
Target for devnet-2
fixes: #8760