-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Update EIP-7892: Add blob count per tx limit via blobSchedule #9623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ All reviewers have approved. |
7db1d8f
to
cc90fe0
Compare
cc90fe0
to
adb4efd
Compare
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field name in comment should match the json example
Do we also need to invalidate block if tx is higher? |
I suggest we target these changes for 7892 instead of 7594 |
6bc54a6
to
a7503b3
Compare
Co-authored-by: Marc <Marchhill@users.noreply.github.com>
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
We probably should tbh. And it probably should be part of the spec too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Adds blob count per tx limit via blobSchedule
Let's assume 72blob txs are allowed, in such case maximum tx size exceeds 10MiB.
It does not seem like there is an obvious point of failure, especially if we spend more time on tx pool improvements. But in sum it effects confidence in ability to handle extreme load of such big transactions.
In case if the proposal is relevant, there are some ideas what can be the initial limit for 48/72 case:
Can it be like 12-15?