Skip to content

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Apr 10, 2025

Adds blob count per tx limit via blobSchedule

Let's assume 72blob txs are allowed, in such case maximum tx size exceeds 10MiB.

  • Tx pool requires to be adjusted for the worst case scenario of big load of such transactions, it is solvable by evicting enough low cost txs in case of limited storage, but such design can be complex to implement efficiently and may mean an additional dos vector
  • Propagation is slower for such in case of limited throughput, still manageable. 3-4 seconds for the case 10MB/s, 10k nodes, 50 nodes connected
  • Validation of network form of such tx requires 72+ms, which is not a big obstacle, still good to consider
  • Another concern is spending the entire blob space by a single actor, which seems a bit unfair, still it is probably better not to additionally regulate blob space market

It does not seem like there is an obvious point of failure, especially if we spend more time on tx pool improvements. But in sum it effects confidence in ability to handle extreme load of such big transactions.
In case if the proposal is relevant, there are some ideas what can be the initial limit for 48/72 case:

  • the most active rollups spend 1-2 blobs on average, let's 10x it in the nearest fork = 12 blobs
  • more manageable tx message size seems to be like 2-3MiB, which = 18-20 blobs
  • the safest option is to allow previous limit like = 9 blobs
    Can it be like 12-15?

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-networking labels Apr 10, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 10, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Apr 10, 2025
@flcl42 flcl42 force-pushed the peerdas-blob-tx-limit branch 4 times, most recently from 7db1d8f to cc90fe0 Compare April 10, 2025 18:44
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field name in comment should match the json example

@benaadams
Copy link
Contributor

Do we also need to invalidate block if tx is higher?

@barnabasbusa
Copy link
Member

I suggest we target these changes for 7892 instead of 7594

@github-actions github-actions bot added s-draft This EIP is a Draft t-informational and removed t-networking s-review This EIP is in Review labels Jun 11, 2025
@eth-bot eth-bot changed the title Update EIP-7594: Add blob count per tx limit via blobSchedule Update EIP-7892: Add blob count per tx limit via blobSchedule Jun 11, 2025
@flcl42 flcl42 force-pushed the peerdas-blob-tx-limit branch from 6bc54a6 to a7503b3 Compare June 11, 2025 09:06
flcl42 and others added 2 commits June 11, 2025 13:30
Co-authored-by: Marc <Marchhill@users.noreply.github.com>
@flcl42 flcl42 requested a review from Marchhill June 11, 2025 10:32
flcl42 and others added 2 commits June 11, 2025 17:25
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
@barnabasbusa
Copy link
Member

barnabasbusa commented Jun 11, 2025

Do we also need to invalidate block if tx is higher?

We probably should tbh. And it probably should be part of the spec too.

Copy link
Contributor

@ethDreamer ethDreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

barnabasbusa added a commit to ethpandaops/ethereum-genesis-generator that referenced this pull request Jun 11, 2025
@eth-bot eth-bot enabled auto-merge (squash) June 11, 2025 17:08
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 79adba6 into ethereum:master Jun 11, 2025
10 checks passed
@flcl42 flcl42 deleted the peerdas-blob-tx-limit branch June 11, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-informational
Projects
None yet
Development

Successfully merging this pull request may close these issues.