Add column family filter to rocksdb x-stats subcommand #8524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
macfarla
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
if you run this subcommand on a non-existent db the error messages are not intuitive - this is not introduced by this PR though
eg
➜ besu git:(rocksdb-stats-filter) ✗ build/install/besu/bin/besu storage rocksdb x-stats -c VARIABLES
Using column family filter: [VARIABLES]
java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
➜ besu git:(rocksdb-stats-filter) ✗ build/install/besu/bin/besu storage rocksdb x-stats
Stats for All Column Families...
java.lang.IllegalArgumentException: You must provide the default column family in your columnFamilyDescriptors
besu/src/main/java/org/hyperledger/besu/cli/subcommands/storage/RocksDbSubCommand.java
Outdated
Show resolved
Hide resolved
…e/RocksDbSubCommand.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Rather than displaying stats for all column families..
Usage
/opt/besu/current/bin/besu --config-file=/etc/besu/config.toml storage rocksdb x-stats -c BLOCKCHAINor
/opt/besu/current/bin/besu --config-file=/etc/besu/config.toml storage rocksdb x-stats --column-family-filter BLOCKCHAIN,TRIE_LOG_STORAGE