[Falcon H1] Fix slow path forward pass #38320
Conversation
…sformers into add-falcon-h1
|
run-slow: falcon_h1 cc @ydshieh anything I should do differently? |
|
@vasqu It's triggered, but failed at a step (reply to comment) and the tests are not run. https://github.com/huggingface/transformers/actions/runs/15250152202/job/42884998108 I'm not sure why, but I will re-run it and see how it goes. |
|
This comment contains run-slow, running the specified jobs: models: ['models/falcon_h1'] |
1 similar comment
|
This comment contains run-slow, running the specified jobs: models: ['models/falcon_h1'] |
|
Slow tests failed, but not sure if this PR caused the failure since we only changed the slow path which is not executed on GPUs, perhaps they failed since the beginning? |
|
We're not able to extract the expected text from the logs and we don't have access to T4 GPUs.. is there a way to extract the output from the logs? |
|
I can update the expected value this afternoon |
|
i pushed a fix in the Integration test |
|
run-slow: falcon_h1 |
|
This comment contains run-slow, running the specified jobs: models: ['models/falcon_h1'] |
@younesbelkada you don't love @ydshieh anymore ? You owe me instructblip .... |
|
ahaha sorry let me give you access now ! yes I owe you that one ... which took so long to fix together |
|
The updated value works for T4. No more need to run-slow Thank you for the effort 🙏 |
|
Thank you very much @ydshieh and HF team for your continuous support ! 🚀 |
|
wait don't merge yet. I will check again and merge once ok |
|
Thanks all guys for your help |
* update * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
* Create push-important-models.yml * feat: add falcon-h1 * fixup * address comment * fix * fix copies * fix copies * fix * fix * fix * fix * fix copies * fix * fix copies * fix test import to at least trigget the cis * yups * update * fix make fix copies * fix inits? * fix style * skip annoying test * add integration test for Falcon H1 * fix copies * fix * fix typo * make style * fix slow path generations * clean debug traces * debug * remove debug traces final confirmation * clean debug traces final * fix format and lineup * make style * debug * Update src/transformers/models/falcon_h1/modular_falcon_h1.py Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com> * adress comments * fix fix-copies * fix integration test * Merge pull request huggingface#7 from ydshieh/fix-slow-path update * another update (huggingface#8) * update * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com> --------- Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Co-authored-by: Younes Belkada <younesbelkada@gmail.com> Co-authored-by: younesbelkada <younes.belkada@tii.ae> Co-authored-by: Arthur Zucker <arthur.zucker@gmail.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com> Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com> Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This PR:
torch_forwardrepeat->repeat_interleavesee Fix Mamba2 Grouped SSD Support in the torch_forward Path #37533@ArthurZucker