Skip to content

Change default value of attn_temperature_tuning #37501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Change default value of attn_temperature_tuning #37501

merged 2 commits into from
Apr 15, 2025

Conversation

gmlwns2000
Copy link
Contributor

What does this PR do?

Fixes #37479

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Cyrilvallez @Rocketknight1

@github-actions github-actions bot marked this pull request as draft April 14, 2025 17:03
@github-actions GitHub Actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@gmlwns2000 gmlwns2000 marked this pull request as ready for review April 14, 2025 17:04
Cyrilvallez
Cyrilvallez approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot for making that clearer! 🤗

@Cyrilvallez Cyrilvallez merged commit d6ac923 into huggingface:main Apr 15, 2025
15 of 18 checks passed
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
@gmlwns2000
Change default value of attn_temperature_tuning (huggingface#37501)
225eceb 
fix: change default value of `attn_temperature_tuning`
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@gmlwns2000 @zucchini-nlp
Change default value of attn_temperature_tuning (huggingface#37501)
a096333 
fix: change default value of `attn_temperature_tuning`
@b8zhong b8zhong mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyrilvallez Cyrilvallez Cyrilvallez approved these changes

@ArthurZucker ArthurZucker Awaiting requested review from ArthurZucker

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mismatching default value of Llama4TextConfig attn_temperature_tuning between official llama code
2 participants
@gmlwns2000 @Cyrilvallez