Skip to content

docs: ko: sagemaker.mdx #22509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2023
Merged

docs: ko: sagemaker.mdx #22509

merged 1 commit into from
Apr 3, 2023

Conversation

jungnerd
Copy link
Contributor

@jungnerd jungnerd commented Apr 1, 2023 •
edited
Loading

What does this PR do?

Part of #20179 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@wonhyeongseo, @HanNayeoniee, @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy
Team Pseudo-Lab, please review this PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 1, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@wonhyeongseo
Copy link
Contributor

wonhyeongseo commented Apr 1, 2023 •
edited
Loading

Also please mention @HanNayeoniee instead of your id(@jungnerd) for requesting review on the last 2 lines of your main PR message. Thank you.

Edit: or just add her 😄 your choice really. Thank you so much for participating on Saturday's meeting.

@jungnerd
Copy link
Contributor Author

jungnerd commented Apr 1, 2023

Also please mention @HanNayeoniee instead of your id(@jungnerd) for requesting review on the last 2 lines of your main PR message. Thank you.

Edit: or just add her 😄 your choice really. Thank you so much for participating on Saturday's meeting.

Thanks for telling me. I've fixed the commit.🤭

@wonhyeongseo wonhyeongseo mentioned this pull request Apr 1, 2023
Open
84 tasks
@wonhyeongseo
Copy link
Contributor

We should also update _toctree.yml, and I can help with this anytime. Please feel free to ping me on KakaoTalk. 🙌

sgugger
sgugger approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contibution!

@sgugger sgugger merged commit 1194c3e into huggingface:main Apr 3, 2023
@HanNayeoniee
Copy link
Contributor

HanNayeoniee commented Apr 3, 2023 •
edited
Loading

Great work! First PR of Pseudo-lab team!
I think [WIP] tag needs to be removed since translation is all done and it's been merged.

@jungnerd jungnerd changed the title [WIP] docs: ko: sagemaker.mdx docs: ko: sagemaker.mdx Apr 4, 2023
raghavanone pushed a commit to raghavanone/transformers that referenced this pull request Apr 5, 2023
@jungnerd @raghavanone
[WIP] docs: ko: sagemaker.mdx (huggingface#22509)
aa1a366 
docs: ko: sagemaker.mdx
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@jungnerd @novice03
[WIP] docs: ko: sagemaker.mdx (huggingface#22509)
50e7f88 
docs: ko: sagemaker.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jungnerd @HuggingFaceDocBuilderDev @wonhyeongseo @HanNayeoniee @sgugger