Skip to content

🌐 [i18n-KO] Translated audio_classification.mdx to Korean #26200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2023
Merged

🌐 [i18n-KO] Translated audio_classification.mdx to Korean #26200

merged 6 commits into from
Sep 25, 2023
+333 −4

Conversation

gabrielwithappy
Copy link
Contributor

@gabrielwithappy gabrielwithappy commented Sep 16, 2023 •
edited
Loading

What does this PR do?

Translated the audio_classification.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@gabrielwithappy gabrielwithappy changed the title 🌐 [i18n-KO] Translated audio_classification.mdx to Korean [WIP] 🌐 [i18n-KO] Translated audio_classification.mdx to Korean Sep 16, 2023
@gabrielwithappy gabrielwithappy marked this pull request as ready for review September 16, 2023 14:40
@gabrielwithappy gabrielwithappy changed the title [WIP] 🌐 [i18n-KO] Translated audio_classification.mdx to Korean 🌐 [i18n-KO] Translated audio_classification.mdx to Korean Sep 16, 2023
@gabrielwithappy
Copy link
Contributor Author

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

wonhyeongseo
wonhyeongseo suggested changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Section is complete, tysm @gabrielwithappy !

@gabrielwithappy @wonhyeongseo
Update docs/source/ko/_toctree.yml
511f51b 
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
@gabrielwithappy
Copy link
Contributor Author

@wonhyeongseo
I updated your suggestion!
Thank you for your feedback. :-)

0525hhgus
0525hhgus suggested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다 😀
오디오 관련 용어를 꼼꼼하게 번역해주셔서 수월하게 이해했습니다 👍
아래 리뷰를 남기니, 참고 부탁드립니다!

@gabrielwithappy
Copy link
Contributor Author

좋은 번역 감사합니다 😀
오디오 관련 용어를 꼼꼼하게 번역해주셔서 수월하게 이해했습니다 👍
아래 리뷰를 남기니, 참고 부탁드립니다!

꼼꼼한 리뷰 너무감사 드립니다!!🤗

gabrielwithappy
gabrielwithappy commented Sep 25, 2023
View reviewed changes
Copy link
Contributor Author

@gabrielwithappy gabrielwithappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update review

@gabrielwithappy
Copy link
Contributor Author

@sgugger, @ArthurZucker, @eunseojo
May you please review this PR?

@LysandreJik
Copy link
Member

cc @stevhliu for review :)

@stevhliu stevhliu mentioned this pull request Sep 25, 2023
Open
84 tasks
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation! 😄

@stevhliu stevhliu merged commit 5e09af2 into huggingface:main Sep 25, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@gabrielwithappy @wonhyeongseo
@hyeonseo2 @parambharat
🌐 [i18n-KO] Translated audio_classification.mdx to Korean (huggingf…
0c75a94 
…ace#26200)

* 🌐 [i18n-KO] Translated  to Korean

* update translation

* fix some sentence editing and fixing punctuation

* Update docs/source/ko/_toctree.yml

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>

* Apply suggestions from code review

Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>

---------

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Co-authored-by: Hyeonseo Yun <0525yhs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

+2 more reviewers

@wonhyeongseo wonhyeongseo wonhyeongseo requested changes

@0525hhgus 0525hhgus 0525hhgus requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielwithappy @LysandreJik @HuggingFaceDocBuilderDev @wonhyeongseo @0525hhgus @stevhliu