🌐 [i18n-KO] Translated `contributing.md` to Korean #25877

mjk0618 · 2023-08-30T16:43:39Z

What does this PR do?

Translated the contributing.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

Check for missing / redundant translations (번역 누락/중복 검사)
Grammar Check (맞춤법 검사)
Review or Add new terms to glossary (용어 확인 및 추가)
Check Inline TOC (e.g. [[lowercased-header]])
Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@bolizabeth, @nuatmochoi, @heuristicwave, @mjk0618, @keonju2, @harheem, @HongB1, @junejae, @54data, @seank021, @augustinLib, @sronger, @TaeYupNoh, @kj021, @eenzeenee

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

…mers into ko-contributing

CONTRIBUTING_ko.md

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

…mers into ko-contributing

stevhliu

Thanks for the translation! 🤗

Can you copy the contents of CONTRIBUTING_ko.md into contributing.md? We should just have one file for this.

mjk0618 · 2023-08-31T16:06:23Z

Thanks for the translation! 🤗

Can you copy the contents of CONTRIBUTING_ko.md into contributing.md? We should just have one file for this.

Thank you for reviewing the translation!

In that case, should I delete the CONTRIBUTING_ko.md file in the root directory and just leave the contributing.md file in the docs/source/ko directory? The reason I added the CONTRIBUTING_ko.md file in the root directory is because the contributing.md file in the original English document had a different directory structure compared to the other documents.

stevhliu · 2023-09-01T16:20:51Z

Oh nevermind, I see what you mean! You can feel free to mark the PR as ready for review and we can merge!

mjk0618 · 2023-09-02T14:14:59Z

Oh nevermind, I see what you mean! You can feel free to mark the PR as ready for review and we can merge!

Thank you for your help! I marked the PR as ready for review. Could you please review and merge it?

mjk0618 · 2023-09-05T05:44:25Z

May you please review this PR? @sgugger, @ArthurZucker, @eunseojo

stevhliu · 2023-09-05T18:38:25Z

@ArthurZucker, I think the build_pr_documentation test is failing because docs/source/ko/contributing.md is just a path to the actual docs and the generate_frontmatter_in_text function is expecting a level 1 header. Would it still be ok to merge this PR?

ArthurZucker · 2023-09-06T18:52:58Z

@stevhliu would be better if we find a fix! It's my first time seeing this so not really sure

mjk0618 · 2023-09-08T06:38:01Z

@stevhliu Thank you for reviewing my PR! Then, should I try to fix something so that the error does not occur? I think I have to try to find out the reason for the error, if I can help fixing the problem. If it's something I can't do, would it be better to wait while translating other documents?

stevhliu · 2023-09-08T18:42:33Z

I think it's an issue with the test not recognizing the path to contributing_ko.md in the docs. We'll look into this issue, but in the meantime, feel free to keep up the good work translating other docs. This issue is probably only affecting this specific doc. 🙂

stevhliu · 2023-09-11T15:20:38Z

docs/source/ko/contributing.md

@@ -0,0 +1 @@
+../../../CONTRIBUTING_ko.md


I think the simplest solution would be to copy everything from CONTRIBUTING_ko.md into contributing.md. Then we can update the original English CONTRIBUTING.md doc with a link to the Korean one in the docs.

Before I make a new commit, I wanted to confirm if I understood correctly. Then, should I delete the CONTRIBUTING_ko.md file I added to the root directory, and copy all the contents to docs/source/ko/contributing.md file?

Thank you for your help! I've just finished what I should do.

Nothing left to do except merge! 🚀

HuggingFaceDocBuilderDev · 2023-09-12T15:30:08Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu

Great work! Thanks for being patient and working with us on this 😄

mjk0618 · 2023-09-12T15:38:19Z

Great work! Thanks for being patient and working with us on this 😄

Thank you so much for helping me complete this work successfully! Have a nice day!

* docs: ko-contributing.md * feat: chatGPT draft * feat: manual edits * feat: change linked document * fix: resolve suggestion Co-authored-by: Haewon Kim <ehdvkf02@naver.com> * fix: resolve suggestion Co-authored-by: Haewon Kim <ehdvkf02@naver.com> * fix: resolve suggestion Co-authored-by: Haewon Kim <ehdvkf02@naver.com> * fix: resolve suggestion Co-authored-by: Haewon Kim <ehdvkf02@naver.com> * fix: resolve suggestion Co-authored-by: Haewon Kim <ehdvkf02@naver.com> * fix: resolve suggestion Co-authored-by: Haewon Kim <ehdvkf02@naver.com> * fix: resolve suggestion Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com> * fix: resolve suggestion Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com> * fix: resolve suggestion Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com> * fix: resolve suggestion * fix: resolve suggestion * feat: delete file to resolve error --------- Co-authored-by: Haewon Kim <ehdvkf02@naver.com> Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

mjk0618 and others added 6 commits August 30, 2023 02:57

docs: ko-contributing.md

7df9937

feat: chatGPT draft

8c14aa8

feat: manual edits

6bdeeae

Merge branch 'huggingface:main' into ko-contributing

9b5b1ca

feat: change linked document

b486c80

Merge branch 'ko-contributing' of https://github.com/mjk0618/transfor…

0096092

…mers into ko-contributing

seank021 reviewed Aug 30, 2023

View reviewed changes

CONTRIBUTING_ko.md Outdated Show resolved Hide resolved

CONTRIBUTING_ko.md Outdated Show resolved Hide resolved

CONTRIBUTING_ko.md Outdated Show resolved Hide resolved

stevhliu mentioned this pull request Aug 30, 2023

🌐 [i18n-KO] Translating docs to Korean #20179

Open

84 tasks

54data reviewed Aug 31, 2023

View reviewed changes

nuatmochoi suggested changes Aug 31, 2023

View reviewed changes

CONTRIBUTING_ko.md Outdated Show resolved Hide resolved

CONTRIBUTING_ko.md Outdated Show resolved Hide resolved

CONTRIBUTING_ko.md Outdated Show resolved Hide resolved

mjk0618 changed the title ~~🌐 [i18n-KO] contributing.md to Korean~~ 🌐 [i18n-KO] Translated contributing.md to Korean Aug 31, 2023

mjk0618 and others added 12 commits August 31, 2023 17:37

fix: resolve suggestion

f69058c

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

fix: resolve suggestion

3f0107b

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

fix: resolve suggestion

8d95c3c

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

fix: resolve suggestion

59d8d0a

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

fix: resolve suggestion

86708e6

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

fix: resolve suggestion

3a15ad7

Co-authored-by: Haewon Kim <ehdvkf02@naver.com>

fix: resolve suggestion

4cef3c2

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

fix: resolve suggestion

e4cd46a

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

fix: resolve suggestion

59c5db2

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

fix: resolve suggestion

7c37b5a

Merge branch 'ko-contributing' of https://github.com/mjk0618/transfor…

824e6cb

…mers into ko-contributing

fix: resolve suggestion

fcca4ad

stevhliu reviewed Aug 31, 2023

View reviewed changes

mjk0618 marked this pull request as ready for review September 1, 2023 18:40

Merge branch 'huggingface:main' into ko-contributing

ee3bda7

mjk0618 added 2 commits September 6, 2023 23:48

Merge branch 'huggingface:main' into ko-contributing

a2f12ef

Merge branch 'huggingface:main' into ko-contributing

c5ea7e2

Merge branch 'huggingface:main' into ko-contributing

53ee078

stevhliu reviewed Sep 11, 2023

View reviewed changes

feat: delete file to resolve error

8bc18e1

stevhliu approved these changes Sep 12, 2023

View reviewed changes

stevhliu merged commit 92f2fba into huggingface:main Sep 12, 2023

ArthurZucker mentioned this pull request Sep 26, 2023

[i18n-DE] Complete first toc chapter #26311

Merged

8 tasks

		@@ -0,0 +1 @@
		../../../CONTRIBUTING_ko.md

🌐 [i18n-KO] Translated contributing.md to Korean #25877

🌐 [i18n-KO] Translated contributing.md to Korean #25877

Uh oh!

Conversation

mjk0618 commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Before reviewing

Who can review? (Initial)

Before submitting

Who can review? (Final)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevhliu left a comment

Choose a reason for hiding this comment

Uh oh!

mjk0618 commented Aug 31, 2023

Uh oh!

stevhliu commented Sep 1, 2023

Uh oh!

mjk0618 commented Sep 2, 2023

Uh oh!

mjk0618 commented Sep 5, 2023

Uh oh!

stevhliu commented Sep 5, 2023

Uh oh!

ArthurZucker commented Sep 6, 2023

Uh oh!

mjk0618 commented Sep 8, 2023

Uh oh!

stevhliu commented Sep 8, 2023

Uh oh!

stevhliu Sep 11, 2023

Choose a reason for hiding this comment

Uh oh!

mjk0618 Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevhliu Sep 12, 2023

Choose a reason for hiding this comment

Uh oh!

mjk0618 Sep 12, 2023

Choose a reason for hiding this comment

Uh oh!

stevhliu Sep 12, 2023

Choose a reason for hiding this comment

Uh oh!

HuggingFaceDocBuilderDev commented Sep 12, 2023

Uh oh!

stevhliu left a comment

Choose a reason for hiding this comment

Uh oh!

mjk0618 commented Sep 12, 2023

Uh oh!

Uh oh!

🌐 [i18n-KO] Translated `contributing.md` to Korean #25877

🌐 [i18n-KO] Translated `contributing.md` to Korean #25877

mjk0618 commented Aug 30, 2023 •

edited

Loading

mjk0618 Sep 12, 2023 •

edited

Loading