Skip to content

Conversation

harheem
Copy link
Contributor

@harheem harheem commented Aug 28, 2023

What does this PR do?

Translated the llm_tutorial.md file of the documentation to Korean 😄
Thank you in advance for your review!

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@bolizabeth, @nuatmochoi, @heuristicwave, @mjk0618, @keonju2, @harheem, @HongB1, @junejae, @54data, @seank021, @augustinLib, @sronger, @TaeYupNoh, @kj021, @eenzeenee

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@harheem harheem marked this pull request as ready for review August 28, 2023 06:22
@harheem harheem changed the title [i18n-KO] Translated llm_tutorial.md to Korean [i18n-KO] Translated llm_tutorial.md to Korean Aug 28, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@harheem harheem changed the title [i18n-KO] Translated llm_tutorial.md to Korean 🌐[i18n-KO] Translated llm_tutorial.md to Korean Aug 29, 2023
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로 추가된 문서지만 꼼꼼하게 번역해주셨군요! 좋은 번역 감사합니다 👍
아래 짧은 리뷰 남겼으며, 다른 리뷰 사항은 없습니다 😄

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one small typo to fix and then we're ready to merge! 😄

@stevhliu stevhliu merged commit fa522d8 into huggingface:main Sep 6, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* docs: ko: llm_tutoroal.md

* feat: chatgpt draft

* fix: manual edits

* fix: resolve suggestions

* fix: resolve suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants