Fix error for GPT-5 not supporting the stop parameter
#1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gpt-5 series do not support the `stop` parameter
stop parameterstop parameter
stop parameterstop parameter
albertvillanova
approved these changes
Aug 8, 2025
|
Is this change reflected in v1.21.0? |
|
@KingJacM, no, this PR was merged just after the v1.21.0 release. |
5 tasks
|
Would be lovely to have a new release with that fix in. |
albertvillanova
pushed a commit
that referenced
this pull request
Aug 11, 2025
|
Thanks for the suggestion, @de-code: we just made a patch release with the fix for GPT-5: https://github.com/huggingface/smolagents/releases/tag/v1.21.1 |
|
I think a few additional changes might be needed to allow |
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gpt-5,gpt-5-mini, andgpt-5-nanomodels do not support thestopparameter.