fix caching #336
Merged
fix caching #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
reviewed
Nov 2, 2022
added 3 commits
November 7, 2022 16:19
|
Added some comments and a few tests. |
NimaBoscarino
pushed a commit
to NimaBoscarino/evaluate
that referenced
this pull request
Nov 9, 2022
* fix caching * fix style * fix exception * add comments * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current caching from the hub is not working properly. The reason is that a canonical metric is internally converted to hub namespace including the organization and the caching replaces
/with--in the cache directory name. Thus the following caching occurs:accuracy-->evaluate-metrics/accuracy-->evaluate-metrics--accuracyHowever, when trying to load the cache only
accuracyis searched which is why the caching always fails. Similarly for community metrics. This PR fixes that issue by fixing the lookup paths.Fixes #294