RFC 6265bis: Clarify same-site for reload navigations #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@englehardt @miketaylr @sbingler -- PTAL, thanks! |
sbingler
reviewed
Jan 25, 2021
|
LGTM, thanks! |
|
LGTM, modulo sbingler comment. |
|
@mikewest PTAL, thanks! |
|
LGTM |
|
@chlily1 can you also add a changelog entry? At that point, it's probably good to land given @englehardt's LGTM. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 27, 2021
The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 27, 2021
The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053934 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#905760}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 27, 2021
The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053934 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#905760}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 30, 2021
… WPTs, a=testonly Automatic update from web-platform-tests Fix and re-enable SameSite cookie reload WPTs The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053934 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#905760} -- wpt-commits: 48b6d27f1fc41d82b71a22daa4cf1a0698bddc02 wpt-pr: 29796
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 31, 2021
… WPTs, a=testonly Automatic update from web-platform-tests Fix and re-enable SameSite cookie reload WPTs The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053934 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#905760} -- wpt-commits: 48b6d27f1fc41d82b71a22daa4cf1a0698bddc02 wpt-pr: 29796
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Aug 4, 2021
… WPTs, a=testonly Automatic update from web-platform-tests Fix and re-enable SameSite cookie reload WPTs The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053934 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#905760} -- wpt-commits: 48b6d27f1fc41d82b71a22daa4cf1a0698bddc02 wpt-pr: 29796
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Aug 4, 2021
… WPTs, a=testonly Automatic update from web-platform-tests Fix and re-enable SameSite cookie reload WPTs The SameSite cookie WPTs dealing with reloaded pages have been disabled for a long time for failures. A recent spec change clarified the correct behavior for SameSite cookies on reload navigations: httpwg/http-extensions#1384 The reloads used in these tests are renderer-initiated, as opposed to browser-initiated (triggered by user interface elements), so they should be considered same-site requests. The SameSite context of the initial navigation need not be the same as the context of the reloaded navigation. The tests are modified to support two different statuses. One of the tests, involving POST requests, is still failing, but for a different reason, and has been moved to the appropriate section of TestExpectations. Bug: 843945 Change-Id: Ifa5c4431e3761534246c150ead2e1823a712bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3053934 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#905760} -- wpt-commits: 48b6d27f1fc41d82b71a22daa4cf1a0698bddc02 wpt-pr: 29796
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the questions raised in issue #628