Merge 0.22 -> 0.23 #6196
Merged
Merge 0.22 -> 0.23 #6196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaze server enhancements
rossabaker
commented
Mar 27, 2022
Comment on lines
+213
to
+215
| F.delay(logger.error(t)(s"Error running request: $req")).attempt *> | ||
| F.delay { cancelToken = None } *> | ||
| F.delay(closeConnection()) |
There was a problem hiding this comment.
Maybe there should be some guarantees in here instead of the ad hoc attempt. This is just a fairly literal merge.
There was a problem hiding this comment.
Good point. If nobody minds, I would undertake this. And I think this isn't a blocker for current PR.
danicheg
approved these changes
Mar 27, 2022
rossabaker
added a commit
to http4s/blaze
that referenced
this pull request
May 26, 2022
…0328 Merge 0.22 -> 0.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.