Safely ignore invalid Aho-Corasick matches #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htkhiem
added a commit
that referenced
this pull request
Aug 30, 2025
* Safely ignore invalid Aho-Corasick matches * Fix typo * Clean up debug prints
htkhiem
added a commit
that referenced
this pull request
Aug 31, 2025
* Make queue updates asynchronous Basic batch-based queue fetch and update code. There's now an additional HashMap holding weak refs to songs in the queue to facilitate the more complicated update logic. All song objects in the queue now have their queue positions kept up to date efficiently. Remaining problems: the queue listview scroll position reset bug has appeared again and harder to fix this time. * Fix newly inserted songs not having correct queue pos * Safely ignore invalid Aho-Corasick matches (#137) * Safely ignore invalid Aho-Corasick matches * Fix typo * Clean up debug prints * Make queue song remove async And clean up a tonne of warnings :( * Make playlist content load async & clear warnings * Fix crashing when using playerctl next/prev And playing indicator still showing after a stop command * Resolve conflicts * Undo spurious resolutions * Fix Sqlite query & content pages not updating selection on bind * Remove debug print * Use old playlist fetch method for old MPD versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid crashing on invalid artist tag splits (not on character boundaries).