Send PING frame only when ACK flag does not specified #1175
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
added a commit
that referenced
this pull request
Jan 23, 2017
Send PING frame only when ACK flag is not set
|
Thank you for the fix! My understanding is that this bug does not cause a loop against a HTTP/2 client conforming to the specification since H2O never sends a PING frame from itself, but it is good to have this fixed nonetheless. |
|
Oh, I misunderstood about looping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug of loop of PING frame. Currently H2O will respond even if it is a PING frame with the ACK flag enabled. This behavior will cause a loop of PING frame.