Pushes: support a x-http2-push-only attribute #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this is set, H2O will interpret the `rel=preload` link as a header we only want to use for H2 pushes, rather than something we also want to push to the client. So we'll be removing that attribute from the link header. If there's only one link, we remove the full header. This is change is there to allow HTTP/1 clients to express HTTP/2 pushes in a way that doesn't affect the response sent to the client.
kazuho
reviewed
Jan 18, 2017
| } | ||
| } | ||
|
|
||
| if (!nopush && preload) | ||
| push_one_path(pool, &paths_to_push, &url, base_path, input_scheme, input_authority, base_scheme, base_authority); | ||
| } while (token != NULL); |
There was a problem hiding this comment.
How about doing the parsing and the rebuilding of filtered_value in one pas?
I suggest this because it wouldn't be too difficult to retain the start and end of each link element, and use it to build filtered value at the end of this do-while loop.
The start of the element can be calculated as url.base - 1 (or you might want to retain url with the surrounding brackets until passing the value to push_one_path).
The end of the element can be calculated as token != NULL ? token : value + value_len.
|
Thank you for your feedback. 83ba870 has a version that does the transform in a single pass. |
An improvement suggested by Kazuho: try to have the best of both worlds: we only allocate from the pool if we know we're going to filter values, otherwise, we don't allocate anything.
fe37365 to
8d937ff
Compare
kazuho
added a commit
that referenced
this pull request
Jan 20, 2017
Pushes: support a x-http2-push-only attribute
|
Thank you for the changes! Merged with small fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is set, H2O will interpret the
rel=preloadlink as a headerwe only want to use for H2 pushes, rather than something we also want to
push to the client. So we'll be removing that attribute from the link
header. If there's only one link, we remove the full header.
This is change is there to allow HTTP/1 clients to express HTTP/2 pushes
in a way that doesn't affect the response sent to the client.