MetadataQuery: make metadata server hostname overrideable #32496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
approved these changes
Feb 28, 2023
apolcyn
added a commit
that referenced
this pull request
Mar 1, 2023
…e server that immediatley closes the connection (#32499) Alongside #32496, this makes this test behave the same on all platforms. FWIW, I verified this causes us to see the previous lock cycle problem in #32491 on linux - originally that lock cycle was only on mac, because of environmental differences between mac and linux in CI.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
In grpc#32294 , we accidentally stopped plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to the metadata server http queries. So, we stopped actually using the fake metadata servers injected in https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48. The brings that back.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…e server that immediatley closes the connection (grpc#32499) Alongside grpc#32496, this makes this test behave the same on all platforms. FWIW, I verified this causes us to see the previous lock cycle problem in grpc#32491 on linux - originally that lock cycle was only on mac, because of environmental differences between mac and linux in CI.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
In #32294 , we accidentally stopped plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to the metadata server http queries. So, we stopped actually using the fake metadata servers injected in https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48. The brings that back.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…e server that immediatley closes the connection (#32499) Alongside #32496, this makes this test behave the same on all platforms. FWIW, I verified this causes us to see the previous lock cycle problem in #32491 on linux - originally that lock cycle was only on mac, because of environmental differences between mac and linux in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32294 , we accidentally stopped plumbing
grpc.testing.google_c2p_resolver_metadata_server_overrideto the metadata server http queries. So, we stopped actually using the fake metadata servers injected ingrpc/test/core/client_channel/resolvers/google_c2p_resolver_test.cc
Line 48 in b3d6800
The brings that back.