Skip to content

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Aug 5, 2021

Reason for re-experimentalizing - PR #26543 to de-experimentalize XdsServerBuilder has not yet made it to a release and there might be some modifications needed here.

@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Aug 5, 2021
@yashykt yashykt requested a review from markdroth August 5, 2021 21:08
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Please make sure to back-port to 1.40.

@yashykt
Copy link
Member Author

yashykt commented Aug 6, 2021

Known issues: #26595, #26885
The MacOS failures seem to be transient tool failures

@yashykt yashykt merged commit 29d220a into grpc:master Aug 6, 2021
yashykt added a commit to yashykt/grpc that referenced this pull request Aug 6, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
yashykt added a commit that referenced this pull request Aug 9, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
dennycd pushed a commit to dennycd/grpc that referenced this pull request Aug 10, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
yashykt added a commit that referenced this pull request Aug 10, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
dennycd pushed a commit to dennycd/grpc that referenced this pull request Aug 11, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
dennycd pushed a commit to dennycd/grpc that referenced this pull request Aug 11, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
Vignesh2208 pushed a commit to Vignesh2208/grpc that referenced this pull request Aug 20, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
Vignesh2208 pushed a commit to Vignesh2208/grpc that referenced this pull request Aug 20, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
@yashykt yashykt deleted the ReexperimentalizeXdsServerBuilder branch May 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants