Add Python PSM security example #26170
Conversation
Yes. Ideally we will mention a release tag to fetch the example and that will be a 1.37.n (it will have to be 1.37.2 when it does come out) |
|
I don't think backporting it is necessary. Why can't we just have it work from head? |
One issue is that
To the best of my knowledge, this example is the only thing that would require a patch release, which involves a full release of binary artifacts. Would it not be sufficient to just link to the |
We are going to document this in the UG and if the head changes (for whatever reason) we still want the documented examples links in the UG to work. The probability is very very small that head won't work can't be guaranteed. |
There are no release artifacts related to the |
Branches, commits, and tags can all be downloaded from GitHub as zip/tarball over HTTP. For example: https://github.com/grpc/grpc/archive/refs/heads/master.tar.gz My question was really about whether we really need to go through the whole patch release process for this? |
No. |
There was a problem hiding this comment.
The only issue I see is that we don't have a maintenance port for health checking. What we want to have is the server listening on two ports always. for example, 50051 and 50052. 50051 (secure/insecure) would be the port on which the server actually serves greeter requests while 50052 (always insecure) would be just for health checking.
|
@yashykt Nice catch! Should be fixed now. |
* Add Python PSM security example * Fix lint * Add in maintenance port configuration * Align CLI flags with Java * Pylint
* Add Python PSM security example * Fix lint * Add in maintenance port configuration * Align CLI flags with Java * Pylint
@sanjaypujare Does this need to be backported to the v1.37.x branch as well?