Grpc.Tools: Use x64 protoc on macOS arm64 #26080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtattermusch
reviewed
May 4, 2021
src/csharp/Grpc.Tools/build/_protobuf/Google.Protobuf.Tools.targets
Outdated
Show resolved
Hide resolved
jtattermusch
suggested changes
May 4, 2021
fe74579 to
b33fbf5
Compare
|
@jtattermusch Thank you, can you give this new version a look? |
|
I started an adhoc run of package build and distribtest: https://fusion2.corp.google.com/invocations/6aedd5f1-57dc-443f-a335-f2320090f7e2/targets I will post results later. |
jtattermusch
approved these changes
May 5, 2021
|
@apolcyn please add another Gooogler's review. |
|
One more run of distribtests: |
apolcyn
approved these changes
May 5, 2021
|
Distribtests are green: https://fusion2.corp.google.com/invocations/7a23e587-b8cc-4512-a8dd-8ca0bcaecef3 (except of distribtest.python_linux_x64_ubuntu1604, which is unrelated and is being fixed). |
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 7, 2021
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a workaround until #25755 is resolved.
@markdroth