Skip to content

Revert "CSDS Implementation" #25745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

Revert "CSDS Implementation" #25745

merged 1 commit into from
Mar 17, 2021

Conversation

lidizheng
Copy link
Contributor

@lidizheng lidizheng commented Mar 17, 2021 •
edited
Loading

Reverts #25038.

Failed the import. CSDS proto is not part of "core" component.

@lidizheng lidizheng added the release notes: no Indicates if PR should not be in release notes label Mar 17, 2021
@lidizheng lidizheng requested a review from veblush March 17, 2021 18:35
@lidizheng lidizheng requested a review from markdroth as a code owner March 17, 2021 18:35
@lidizheng lidizheng enabled auto-merge (squash) March 17, 2021 19:15
@lidizheng lidizheng merged commit 98fd4e1 into master Mar 17, 2021
lidizheng added a commit that referenced this pull request Mar 17, 2021
@lidizheng
Revert "Revert "CSDS Implementation (#25038)" (#25745)"
2710bbc 
This reverts commit 98fd4e1.
@lidizheng lidizheng mentioned this pull request Mar 17, 2021
Closed
lidizheng added a commit to lidizheng/grpc that referenced this pull request Mar 18, 2021
@lidizheng
Revert "Revert "CSDS Implementation (grpc#25038)" (grpc#25745)"
1b41d66 
This reverts commit 98fd4e1.
@lidizheng lidizheng mentioned this pull request Mar 18, 2021
Merged
lidizheng added a commit to lidizheng/grpc that referenced this pull request Mar 19, 2021
@lidizheng
Revert "Revert "CSDS Implementation (grpc#25038)" (grpc#25745)"
14d221c 
This reverts commit 98fd4e1.
lidizheng added a commit to lidizheng/grpc that referenced this pull request Mar 22, 2021
@lidizheng
Revert "Revert "CSDS Implementation (grpc#25038)" (grpc#25745)"
fddbcd7 
This reverts commit 98fd4e1.
lidizheng added a commit that referenced this pull request Mar 22, 2021
@lidizheng
Re-introduce "CSDS Implementation" (#25762)
1040fbd 
* Revert "Revert "CSDS Implementation (#25038)" (#25745)"

This reverts commit 98fd4e1.

* Add xDS special Bazel build rules

* Add 2 todos to remove the added rules
@stanley-cheung stanley-cheung deleted the revert-25038-csds branch April 8, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth approved these changes

+1 more reviewer

@veblush veblush veblush approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@veblush veblush

@markdroth markdroth

Labels
lang/c++ lang/core release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidizheng @veblush @markdroth @grpc-kokoro