Add ruby 3.0 support for mac binary packages #25429

apolcyn · 2021-02-12T00:31:07Z

Kicked off an artifact run in: https://fusion2.corp.google.com/invocations/0e763400-0be8-47b6-b4ff-12b2434d989e/targets

dazuma · 2021-03-03T00:59:30Z

@apolcyn Is something holding this up?

apolcyn · 2021-03-03T05:22:59Z

@dazuma sorry progress on this has been slow, but I do plan to get this into the upcoming release. Currently, this PR is stuck on the following error:

cd -
mkdir -p /Users/kbuilder/.rake-compiler/sources/ruby-2.7.0
cd /Users/kbuilder/.rake-compiler/sources
tar xf ruby-2.7.0.tar.bz2
cd -
cd /Users/kbuilder/.rake-compiler/builds/x86_64-darwin11/ruby-2.7.0
/Users/kbuilder/.rake-compiler/sources/ruby-2.7.0/configure --host=x86_64-darwin11 --target=x86_64-darwin11 --build=x86_64-apple-darwin18.7.0 --enable-static --disable-shared --disable-install-doc --without-gmp --with-ext= LDFLAGS=-pipe -s --prefix=/Users/kbuilder/.rake-compiler/ruby/x86_64-darwin11/ruby-2.7.0
checking for ruby... /Users/kbuilder/.rvm/rubies/ruby-2.7.0/bin/ruby
tool/config.guess already exists
tool/config.sub already exists
checking build system type... x86_64-apple-darwin18.7.0
checking host system type... x86_64-pc-darwin11
checking target system type... x86_64-pc-darwin11
checking for x86_64-darwin11-clang... no
checking for x86_64-darwin11-gcc... no
checking for x86_64-darwin11-cc... no
checking for clang... clang
configure: WARNING: using cross tools not prefixed with host triplet
checking for x86_64-darwin11-gcc... clang
checking for x86_64-darwin11-gcc... (cached) clang
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... yes
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking for clang option to accept ISO C99... none needed
checking for x86_64-darwin11-clang++... no
checking for clang++... clang++
checking whether we are using the GNU C++ compiler... yes
checking whether clang++ accepts -g... yes
checking how to run the C preprocessor... clang -E
checking if minimum required OS X version is supported... yes
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether clang++ accepts -g... (cached) yes
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking whether clang needs -traditional... no
checking for x86_64-darwin11-ld... no
checking for ld... ld
checking whether the linker is GNU ld... no
checking whether clang -E accepts -o... yes
checking for x86_64-darwin11-clang-ranlib... no
checking for x86_64-darwin11-ranlib... no
checking for clang-ranlib... (cached) :
checking for x86_64-darwin11-clang-ar... no
checking for x86_64-darwin11-ar... no
checking for clang-ar... (cached) libtool -static
checking for libtool -static flags... (cached) -no_warning_for_no_symbols -o
checking for x86_64-darwin11-as... no
checking for as... as
checking for x86_64-darwin11-objdump... no
checking for x86_64-darwin11-gobjdump... no
checking for objdump... objdump
checking for x86_64-darwin11-objcopy... no
checking for x86_64-darwin11-gobjcopy... no
checking for objcopy... no
checking for gobjcopy... no
checking for x86_64-darwin11-clang-nm... no
checking for x86_64-darwin11-nm... no
checking for clang-nm... no
checking for nm... nm
checking whether ln -s works... yes
checking whether make -j8 sets $(MAKE)... yes
checking for a BSD-compatible install... /usr/local/bin/ginstall -c
checking for a thread-safe mkdir -p... /usr/local/bin/gmkdir -p
checking for x86_64-darwin11-dtrace... no
checking for dot... no
checking for doxygen... no
checking for pkg-config... pkg-config
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking for cd using physical directory... cd -P
checking whether CFLAGS is valid... yes
checking whether LDFLAGS is valid... no
configure: error: something wrong with LDFLAGS="-pipe -s"
rake aborted!
Command failed with status (1): [/Users/kbuilder/.rake-compiler/sources/rub...]
/Volumes/BuildData/tmpfs/src/github/grpc/tmpfile.74o8Xi3S:128:in `block (2 levels) in <top (required)>'
/Volumes/BuildData/tmpfs/src/github/grpc/tmpfile.74o8Xi3S:125:in `block in <top (required)>'
Tasks: TOP => cross-ruby => install => /Users/kbuilder/.rake-compiler/ruby/x86_64-darwin11/ruby-2.7.0/bin/ruby.exe => /Users/kbuilder/.rake-compiler/builds/x86_64-darwin11/ruby-2.7.0/ruby.exe => /Users/kbuilder/.rake-compiler/builds/x86_64-darwin11/ruby-2.7.0/Makefile
(See full trace by running task with --trace)

Please note that this work simplifies the Darwin rubygem build, and addresses inconsistencies in packaging that result in issues like grpc#25060, but introduces some notable changes: - ships "x86_64-darwin" and "arm64-darwin" platform gems - stops shipping "universal-darwin" platform gem - drop support for i386 darwin It's unclear to me whether grpc should continue to support i386 Darwin, and so I'm open to learning more about this. Related to: - grpc#25429 - grpc#25755 - grpc#25756

Using RCD for these platforms unifies the Darwin native gem build process with the Linux native gems, which should help avoid inconsistencies in packaging that result in issues like the missing Ruby 3.0 binaries in grpc#25060. Please note that this change leaves the "universal-darwin" platform native gem untouched, but provides a path forward if the project ever decides to drop "universal" binary support. Related to: - grpc#25429 - grpc#25755 - grpc#25756

apolcyn · 2021-03-31T21:02:50Z

Kicked off a full package build in https://fusion2.corp.google.com/invocations/1be85d06-f857-44bc-b631-52f400778b11/targets since the macos artifact smoke test passed

apolcyn · 2021-04-01T06:41:32Z

passing package build: https://fusion2.corp.google.com/invocations/69a3c64e-de5b-472e-9441-f2b45aa3c0e8/targets/grpc%2Fcore%2Fexperimental%2Fgrpc_build_artifacts_multiplatform/log

Using RCD for this platform unifies the Darwin native gem build process with the Linux native gems, which should help avoid inconsistencies in packaging that result in issues like the missing Ruby 3.0 binaries in grpc#25060. Please note that this change leaves the "universal-darwin" platform native gem untouched, but provides a path forward if the project ever decides to drop "universal" binary support. Related to: - grpc#25429 - grpc#25756

* ruby: use squiggly heredoc for rake-compiler-dock commands * ruby: use `bundler exec` when building native gems * ruby: clean .{bundle,so} from src/ruby/lib when building native gems Failing to remove these files between native builds leads rake-compiler to establish circular dependencies (which may be a bug in rake-compiler, but this feels like an easy and good thing to do, anyway). * ruby: extract linux and darwin RUBY_PLATFORM checks into variables There were already "windows" and "bsd" flags, so let's improve consistency and readability, and set a clear pattern for subsequent flags. * ruby: rely on rake-compiler-dock v1.1.0 to set no_native correctly As of v1.1.0 there's no need to set this explicitly anymore; it will be true whenever the extension is being built in a RCD container. See rake-compiler/rake-compiler-dock@362890d * ruby: add "x86_64-darwin" platform gem Using RCD for this platform unifies the Darwin native gem build process with the Linux native gems, which should help avoid inconsistencies in packaging that result in issues like the missing Ruby 3.0 binaries in #25060. Please note that this change leaves the "universal-darwin" platform native gem untouched, but provides a path forward if the project ever decides to drop "universal" binary support. Related to: - #25429 - #25756

apolcyn added lang/ruby release notes: yes Indicates if PR needs to be in release notes labels Feb 12, 2021

apolcyn force-pushed the ruby_mac_3_binary branch from 565e8de to 3c03b9a Compare February 12, 2021 02:18

apolcyn force-pushed the ruby_mac_3_binary branch from fa4065c to 61bbb03 Compare March 5, 2021 20:09

apolcyn added 5 commits March 8, 2021 11:42

Add ruby 3.0 support for mac binary packages

061a28d

update rake-compiler

539b345

fix patch

27f545b

update patch command

838f66b

Don't set 'LDFLAGS=-pipe -s' on macos

968a237

apolcyn force-pushed the ruby_mac_3_binary branch from 61bbb03 to 968a237 Compare March 8, 2021 19:45

apolcyn added 3 commits March 8, 2021 12:49

workaround fact that 3.0.0 tar.bz2 file hasn't yet been published

87dfbf0

correct sources path

76ec291

correct directory name again

5978e95

apolcyn added the kokoro:force-run label Mar 9, 2021

grpc-kokoro removed the kokoro:force-run label Mar 9, 2021

apolcyn added 3 commits March 8, 2021 22:18

ensure directory exists

96d6a78

use abs path to cross ruby rakefile

f4e3826

install and use ruby 3.0.0 in 3.0.0 artifacts build

832f798

apolcyn added the kokoro:force-run label Mar 9, 2021

grpc-kokoro removed the kokoro:force-run label Mar 9, 2021

apolcyn added 3 commits March 9, 2021 10:28

try prefixing 3.0.0 install with ruby-

50e18ef

upgrade RVM first

59a9c90

add rvm public keys to known keys

ff700ad

flavorjones mentioned this pull request Mar 23, 2021

ruby: build native Darwin gems using rake-compiler-dock #25794

Merged

force use of an ipv4 key server to avoid running into rvm/rvm#4215

10b1024

quartzmo mentioned this pull request Mar 30, 2021

LoadError when retrieving document from Firestore googleapis/google-cloud-ruby#11067

Closed

apolcyn added 3 commits March 30, 2021 20:53

add debug prints

649ade3

adjustment

06bde32

use cd instead of pushd

f796713

apolcyn added the kokoro:force-run label Mar 31, 2021

grpc-kokoro removed the kokoro:force-run label Mar 31, 2021

apolcyn added the kokoro:force-run label Mar 31, 2021

grpc-kokoro removed the kokoro:force-run label Mar 31, 2021

don't use cd

d8df834

add retries to gpg key fetching

ea64a05

apolcyn assigned stanley-cheung Apr 2, 2021

apolcyn mentioned this pull request Apr 2, 2021

Cherry-pick PR #25429 "Add ruby 3.0 support for mac binary packages" to 1.37.x #25869

Merged

stanley-cheung approved these changes Apr 2, 2021

View reviewed changes

apolcyn merged commit 361aa15 into grpc:master Apr 2, 2021

apolcyn mentioned this pull request Apr 19, 2021

Unable to install with Ruby 3.0.0 #25060

Closed

marcotc mentioned this pull request May 28, 2021

Enable gRPC tests for Ruby 3.0 DataDog/dd-trace-rb#1532

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ruby 3.0 support for mac binary packages #25429

Add ruby 3.0 support for mac binary packages #25429

Uh oh!

apolcyn commented Feb 12, 2021 •

edited

Loading

Uh oh!

dazuma commented Mar 3, 2021

Uh oh!

apolcyn commented Mar 3, 2021

Uh oh!

apolcyn commented Mar 31, 2021

Uh oh!

apolcyn commented Apr 1, 2021

Uh oh!

Uh oh!

Add ruby 3.0 support for mac binary packages #25429

Add ruby 3.0 support for mac binary packages #25429

Uh oh!

Conversation

apolcyn commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dazuma commented Mar 3, 2021

Uh oh!

apolcyn commented Mar 3, 2021

Uh oh!

apolcyn commented Mar 31, 2021

Uh oh!

apolcyn commented Apr 1, 2021

Uh oh!

Uh oh!

apolcyn commented Feb 12, 2021 •

edited

Loading