Skip to content

Better slice management for windows reads (for v1.17.x) #17378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2018
Merged

Better slice management for windows reads (for v1.17.x) #17378

merged 2 commits into from
Dec 5, 2018

Conversation

jtattermusch
Copy link
Contributor

Backports #17377 into v1.17.x

@jtattermusch
Copy link
Contributor Author

CC @muxi

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,619      Total (<)     11,175,625

 No significant differences in binary sizes

@grpc-testing
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@jtattermusch
Copy link
Contributor Author

ad the "RELEASE BLOCKER" label: it's totally fine not to block the v1.17.0 release, but this fix seems important enough that v1.17.1 should be started right after releasing v1.17.0. Leaving the decision upon @muxi

@muxi
Copy link
Contributor

muxi commented Dec 3, 2018

Removing the RELEASE BLOCKER label. We'll make v1.17.1 very soon for this and #17354

@jtattermusch
Copy link
Contributor Author

Known failures: #17138

@jtattermusch jtattermusch mentioned this pull request Dec 4, 2018
Closed
@jtattermusch
Copy link
Contributor Author

@nicolasnoble @muxi let's approve this PR and get it merged instead of #17377 (and do upmerge v1.17.x -> master afterwards instead).

muxi
muxi approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@muxi muxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with merging this PR to the release branch. Don't have time to read the code for now, so please make sure someone else look at it too.

@jtattermusch
Copy link
Contributor Author

@nicolasnoble already approved #17377 which is exactly the same code.

@jtattermusch jtattermusch merged commit c9b1662 into grpc:v1.17.x Dec 5, 2018
@jtattermusch jtattermusch mentioned this pull request Dec 6, 2018
Closed
nicolasnoble added a commit that referenced this pull request Dec 14, 2018
@nicolasnoble
Merge pull request #17488 from nicolasnoble/revert-windows-logs
c542d44 
Reverting #17378
@jtattermusch jtattermusch mentioned this pull request Jan 2, 2019
Merged
@jtattermusch jtattermusch added release notes: no Indicates if PR should not be in release notes and removed release notes: yes Indicates if PR needs to be in release notes labels Jan 8, 2019
@jtattermusch
Copy link
Contributor Author

Setting "release notes:no" to prevent this PR from showing up in v1.18 release notes (it's already in v1.17 release notes).

@jtattermusch jtattermusch mentioned this pull request Feb 1, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@muxi muxi muxi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AspirinSJL AspirinSJL

@nicolasnoble nicolasnoble

Labels
lang/core release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jtattermusch @grpc-testing @muxi @AspirinSJL @nicolasnoble