Skip to content

Segmentation fault caused by channel.close() when used with connectivity-state subscriptions #16296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2018
Merged

Segmentation fault caused by channel.close() when used with connectivity-state subscriptions #16296

merged 1 commit into from
Aug 10, 2018

Conversation

ericgribkoff
Copy link
Contributor

@ericgribkoff ericgribkoff commented Aug 9, 2018 •
edited
Loading

Addresses partially addresses #16290

mehrdada
mehrdada approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@mehrdada mehrdada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Thanks!

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,950,829      Total (=)      1,950,829

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,668,835      Total (>)     10,668,833

 No significant differences in binary sizes

@mehrdada mehrdada added kind/bug lang/Python priority/P1 release notes: yes Indicates if PR needs to be in release notes labels Aug 9, 2018
@ericgribkoff
Copy link
Contributor Author

Will address remaining race condition identified in #16290 in a separate PR.

@ericgribkoff ericgribkoff merged commit ea7c0a6 into grpc:master Aug 10, 2018
@e-heller e-heller mentioned this pull request Aug 14, 2018
Closed
srini100 pushed a commit to srini100/grpc that referenced this pull request Aug 21, 2018
@ericgribkoff @srini100
Merge pull request grpc#16296 from ericgribkoff/close_segfault_fix
9969ac7 
Check if Python channel is closed before starting core ops
@srini100 srini100 mentioned this pull request Aug 21, 2018
Merged
srini100 added a commit that referenced this pull request Aug 21, 2018
@srini100
Merge pull request #16405 from srini100/v1.14.x
08bf39a 
Backport PRs #15929 and #16296 from master
@srini100 srini100 changed the title Check if channel is closed before starting core ops Segmentation fault caused by channel.close() when used with connectivity-state subscriptions Aug 21, 2018
@srini100 srini100 mentioned this pull request Sep 11, 2018
Closed
@ghost ghost mentioned this pull request Sep 13, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Nov 20, 2018
@lock lock bot unassigned mehrdada Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/bug lang/Python priority/P1 release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericgribkoff @grpc-testing @mehrdada