refactor CMake build #900
Merged
refactor CMake build #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> some update Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> refactor CMake build Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
MtoLStoN
approved these changes
Nov 21, 2023
foxtran
reviewed
Dec 4, 2023
|
|
||
| # Setup the XTB Project | ||
| # Buggy CMake versions |
There was a problem hiding this comment.
It was fixed since 3.27.9 and in 3.28 it should works now.
See https://gitlab.kitware.com/cmake/cmake/-/issues/25425
gorges97
pushed a commit
to gorges97/xtb
that referenced
this pull request
Mar 27, 2024
* refactor CMake build Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> some update Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> refactor CMake build Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> * Update CMakeLists.txt * allow cmake v 3.17 or newer --------- Signed-off-by: albert <92109627+Albkat@users.noreply.github.com> Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision of the CMake build: