[bug] fix avg_over_time panic when counter series is missing #5300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
approved these changes
Jul 23, 2025
mapno
pushed a commit
to mapno/tempo
that referenced
this pull request
Jul 24, 2025
…#5300) * [bug] fix panic when counter series is missing * changelog * lint
mapno
added a commit
that referenced
this pull request
Jul 24, 2025
ruslan-mikhailov
pushed a commit
to ruslan-mikhailov/tempo
that referenced
this pull request
Jul 29, 2025
…#5300) * [bug] fix panic when counter series is missing * changelog * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The avg_over_time metrics calculation relies on a pair of series per actual value and in some occurrences, if one of the pair is no longer in the resulting time series, a panic occurs. The fix is to check whether the series exist before doing aggregation.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]