ingester: use a 64-bit hash to avoid collisions #5276
Merged
+77
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0df8471 to
c6bc1fa
Compare
mdisibio
reviewed
Jun 13, 2025
We had this issue in the distributor, it it can happen in the ingester too with live traces.
2b72893 to
3080025
Compare
|
@mdisibio I've added a test to check for collisions. I've also run the same test in main and the same span IDs where found in multiple traces, so I can confirm that this fixes the issue for live traces. |
mdisibio
approved these changes
Jun 16, 2025
carles-grafana
added a commit
to carles-grafana/tempo
that referenced
this pull request
Jun 17, 2025
* ingester: use a 64-bit hash to avoid collisions We had this issue in the distributor, it it can happen in the ingester too with live traces. * Update changelog * Add test for live traces collision
carles-grafana
added a commit
to carles-grafana/tempo
that referenced
this pull request
Jun 17, 2025
* ingester: use a 64-bit hash to avoid collisions We had this issue in the distributor, it it can happen in the ingester too with live traces. * Update changelog * Add test for live traces collision
carles-grafana
added a commit
that referenced
this pull request
Jun 18, 2025
* ingester: use a 64-bit hash to avoid collisions We had this issue in the distributor, it it can happen in the ingester too with live traces. * Update changelog * Add test for live traces collision
carles-grafana
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this issue in the distributor (#5186), it it can happen in the ingester too with live traces.
In the ingester we use a map to store live traces where the key is a hash of the Trace ID. Because we were using 32-bit hashes, in cases where tens of thousands of traces were pushed, there was a high chance of collision in which case spans from different traces would be incorrectly combined. By using a 64-bit we minimize the collision chance.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]