Skip to content

Fix to remove some attributes from compare() #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 3, 2025
Merged

Fix to remove some attributes from compare() #5196

merged 7 commits into from
Jun 3, 2025

Conversation

mdisibio
Copy link
Contributor

@mdisibio mdisibio commented Jun 2, 2025 •
edited
Loading

What this PR does:
When we added the intrinsic for parent span ID, it got automatically included in selectAll for the compare() function. But it isn't useful and excluding it will save significant cpu/mem.

                                                                      │ before.txt │             after.txt             │
                                                                      │   sec/op   │   sec/op    vs base               │
BackendBlockQueryRange/{_name_!=_nil_}_|_compare({status=error})/5-14   3.353 ± 2%   2.879 ± 3%  -14.12% (p=0.002 n=6)

                                                                      │ before.txt │             after.txt             │
                                                                      │  MB_IO/op  │  MB_IO/op   vs base               │
BackendBlockQueryRange/{_name_!=_nil_}_|_compare({status=error})/5-14   26.21 ± 0%   19.64 ± 0%  -25.07% (p=0.002 n=6)

                                                                      │ before.txt  │           after.txt            │
                                                                      │  spans/op   │  spans/op    vs base           │
BackendBlockQueryRange/{_name_!=_nil_}_|_compare({status=error})/5-14   819.6k ± 0%   819.6k ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal

                                                                      │ before.txt  │             after.txt              │
                                                                      │   spans/s   │   spans/s    vs base               │
BackendBlockQueryRange/{_name_!=_nil_}_|_compare({status=error})/5-14   244.5k ± 2%   284.7k ± 3%  +16.45% (p=0.002 n=6)

                                                                      │  before.txt   │              after.txt               │
                                                                      │     B/op      │     B/op       vs base               │
BackendBlockQueryRange/{_name_!=_nil_}_|_compare({status=error})/5-14   807.4Mi ± 27%   403.0Mi ± 42%  -50.08% (p=0.002 n=6)

                                                                      │ before.txt  │             after.txt              │
                                                                      │  allocs/op  │  allocs/op   vs base               │
BackendBlockQueryRange/{_name_!=_nil_}_|_compare({status=error})/5-14   6.359M ± 3%   2.746M ± 4%  -56.83% (p=0.002 n=6)

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
Copy link
Collaborator

this may be beyond the scope of your change, but i'm seeing other suspect returned values:

image

and

image

@mdisibio
Copy link
Contributor Author

mdisibio commented Jun 2, 2025

this may be beyond the scope of your change, but i'm seeing other suspect returned values:

The switch statement already excludes nestedSetParent, strange, yeah can take a look.

mdisibio added 3 commits June 2, 2025 14:06
@mdisibio
Fix to ignore nestedSetParent and other intrinisics from compare(). F…
b1db140 
…ix where a nil attribute could be returned from selectall from scopes without any attributes
@mdisibio
changelog
2c0f0b6
@mdisibio
lint
8f307ee
@mdisibio mdisibio changed the title Exclude parent span id from selectAll Fix to remove some attributes from compare() Jun 2, 2025
@mdisibio
Copy link
Contributor Author

mdisibio commented Jun 2, 2025

Pushed 2 fixes:

  1. nestedSetParent - This was being returned because it was part of the first pass. Drilldown runs queries like {nestedSetParent<0 && true} | compare({status = error}, 10). So the fix was to exclude grouping on it in the compare() function itself.

  2. instrumentation/resource. unnamed attributes - This was because a nil unnamed attribute was being created by attributeCollector unintentionally, for any scopes that had zero generic attributes. Because if all keys and values are nil, it's encoded as a single nil at the parent definition level. I think this has been around a while, but rare for span and resource, and really first shown after we added the instrumentation scope. There are a couple ways to filter this out, but I think using the skip nils predicate in createAttributeIterator is the best.

@mdisibio mdisibio marked this pull request as ready for review June 2, 2025 19:25
@mdisibio mdisibio merged commit e0b0f25 into grafana:main Jun 3, 2025
20 checks passed
mdisibio added a commit to mdisibio/tempo that referenced this pull request Jun 3, 2025
@mdisibio
Fix to remove some attributes from compare() (grafana#5196)
3354054 
* Exclude parent span id from selectAll

* update test

* Fix to ignore nestedSetParent and other intrinisics from compare(). Fix where a nil attribute could be returned from selectall from scopes without any attributes

* changelog

* lint

* woops lint again
mdisibio added a commit that referenced this pull request Jun 3, 2025
@mdisibio
Fix to remove some attributes from compare() (#5196) (#5208)
4362db6 
* Exclude parent span id from selectAll

* update test

* Fix to ignore nestedSetParent and other intrinisics from compare(). Fix where a nil attribute could be returned from selectall from scopes without any attributes

* changelog

* lint

* woops lint again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott joe-elliott approved these changes

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

@carles-grafana carles-grafana Awaiting requested review from carles-grafana carles-grafana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdisibio @joe-elliott