Skip to content

Vulture: check recent traces #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025

Conversation

ruslan-mikhailov
Copy link
Contributor

@ruslan-mikhailov ruslan-mikhailov commented May 23, 2025

What this PR does:

  1. Refactoring to simplify code and reduce copy-paste
  2. For reads, do two checks: for recent traces that are <5 minutes old, and for older traces. This allows to check read path that hits to generators and ingesters.

Which issue(s) this PR fixes:
Fixes #

How it has been tested:

  1. unit tests
  2. run the new version in k8s for 4h+. Results: no errors reported

Additionally, checked via debug logs that checks run correctly

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ruslan-mikhailov ruslan-mikhailov force-pushed the vulture-recent-blocks branch from 54fcc94 to 6604866 Compare May 27, 2025 12:25
@ruslan-mikhailov
Copy link
Contributor Author

ruslan-mikhailov commented May 27, 2025

+ review fix: increase default value for tempo-recent-traces-backoff-duration

@ruslan-mikhailov ruslan-mikhailov requested a review from mapno May 27, 2025 12:26
Copy link
Contributor

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruslan-mikhailov ruslan-mikhailov merged commit df1abc5 into grafana:main May 28, 2025
19 checks passed
@ruslan-mikhailov ruslan-mikhailov deleted the vulture-recent-blocks branch May 28, 2025 09:12
knylander-grafana pushed a commit to knylander-grafana/tempo-doc-work that referenced this pull request Jun 2, 2025
* Vulture: add new flag

* Vulture: refactoring to simplify code

* Vulture: query old and recent traces

* Vulture: fix tests after refactoring

* Vulture: tests for checker

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants