Skip to content

Add range condition to bytes predicates #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2024
Merged

Add range condition to bytes predicates #4198

merged 2 commits into from
Oct 16, 2024

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Oct 16, 2024 •
edited
Loading

What this PR does: Remove earlier comment to add range condition to byte predicates.

                                                                     │ before-onlyid.txt │           after-onlyid.txt           │
                                                                     │      sec/op       │    sec/op     vs base                │
BackendBlockTraceQL/trace:id_=_`xxx`-16        17.421m ± 3%   9.895m ± 13%  -43.20% (p=0.000 n=20)

                                                                     │ before-onlyid.txt │           after-onlyid.txt            │
                                                                     │        B/s        │      B/s       vs base                │
BackendBlockTraceQL/trace:id_=_`xxx`-16        540.3Mi ± 3%   837.7Mi ± 11%  +55.03% (p=0.000 n=20)

                                                                     │ before-onlyid.txt │          after-onlyid.txt          │
                                                                     │     MB_io/op      │  MB_io/op   vs base                │
BackendBlockTraceQL/trace:id_=_`xxx`-16          9.870 ± 0%   8.691 ± 0%  -11.95% (p=0.000 n=20)

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ie-pham ie-pham enabled auto-merge (squash) October 16, 2024 18:23
@ie-pham ie-pham merged commit 891e6bb into grafana:main Oct 16, 2024
16 checks passed
@electron0zero electron0zero mentioned this pull request Nov 28, 2024
Closed
@electron0zero electron0zero mentioned this pull request Jan 29, 2025
Closed
@ie-pham ie-pham mentioned this pull request Feb 17, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdisibio mdisibio mdisibio approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner

@annanay25 annanay25 Awaiting requested review from annanay25

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

@javiermolinar javiermolinar Awaiting requested review from javiermolinar javiermolinar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ie-pham @mdisibio