fix(helm): followup PR 12879 in Helm #11140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm/helm#12879 modified merging values for sub-charts in a non-backwards compatible way. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
aknuds1
reviewed
Apr 7, 2025
operations/helm/charts/mimir-distributed/templates/validate.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
cookew
reviewed
Jun 22, 2025
Comment on lines
+257
to
+273
| {{- with .Values.rollout_operator.podSecurityContext -}} | ||
| {{- if hasKey . "fsGroup" -}} | ||
| {{- if ne .fsGroup nil -}} | ||
| {{- fail "You have selected rbac.type=scc, you must set the value of fsGroup to null in rollout_operator.podSecurityContext" -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
| {{- if hasKey . "runAsGroup" -}} | ||
| {{- if ne .runAsGroup nil -}} | ||
| {{- fail "You have selected rbac.type=scc, you must set the value of runAsGroup to null in rollout_operator.podSecurityContext" -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
| {{- if hasKey . "runAsUser" -}} | ||
| {{- if ne .runAsUser nil -}} | ||
| {{- fail "You have selected rbac.type=scc, you must set the value of runAsUser to null in rollout_operator.podSecurityContext" -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
This code compares values to nil and then states they have to be set to null and the error messages aren't specific. The code block above this (lines 248-254) is I think what is needed here. I set fsGroup, runAsGroup, runAsUser under rollout_operator.podSecurityContext to null in my values.yaml file and the error is triggering. Setting the values to nil does not work either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
helm/helm#12879 modified merging values for sub-charts in a non-backwards compatible way.
Which issue(s) this PR fixes or relates to
NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.