fix(mimirtool): Make remote-read actually return data #10286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #9156 probably, all the remote read commands return no data I added a missing error return using `timeseries.Err()` and got this error: `mimirtool: error: chunkedReader: message size exceeded the limit 0 bytes; got: 361 bytes, try --help` which lead me to find that we need to pass in `ChunkedReadLimit` on the client I set it at a default 1 MiB and configurable through a flag
a3fcceb to
dfceee9
Compare
dimitarvdimitrov
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
1MiB is also what mimir uses by default
mimir/pkg/querier/remote_read.go
Lines 37 to 40 in 7485d55
SGTM, but maybe having something like 10-100MiB won't hurt so mimirtool is interoperable with other implementations that might choose slightly higher values.
|
I think the limit before the PR you linked was 50MiB, so we can restore that |
dimitarvdimitrov
approved these changes
Dec 19, 2024
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #9156 probably, all the remote read commands return no data
I added a missing error return using
timeseries.Err()and got this error:mimirtool: error: chunkedReader: message size exceeded the limit 0 bytes; got: 361 bytes, try --helpwhich lead me to find that we need to pass inChunkedReadLimiton the clientI set it at a default 1 MiB and configurable through a flag
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.