update prometheus no client golang at grafana/mimir-prometheus@fdf902d #9156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
…l` flag is enabled
charleskorn
approved these changes
Sep 2, 2024
pstibrany
approved these changes
Sep 2, 2024
| return rdResp.Results[0], nil | ||
|
|
||
| res := rdResp.Results[0] | ||
| return remote.FromQueryResult(sortSeries, res), nil |
There was a problem hiding this comment.
I don't understand why sortSeries is a parameter now. Did the remote-read API also change? Previously they were supposed to be returned sorted by the server. Are we supposed to pass sortSeries to the server?
There was a problem hiding this comment.
Looking at the server side:
https://github.com/prometheus/prometheus/blob/28a830ed9f331e71549c24c2ac3b441033201e8f/storage/remote/read_handler.go#L83
The protocol does not have this option
https://github.com/prometheus/prometheus/blob/28a830ed9f331e71549c24c2ac3b441033201e8f/prompb/remote.proto#L31
https://github.com/prometheus/prometheus/blob/28a830ed9f331e71549c24c2ac3b441033201e8f/prompb/remote.proto#L67
https://github.com/prometheus/prometheus/blob/28a830ed9f331e71549c24c2ac3b441033201e8f/prompb/types.proto#L154
So this is pure client side.
Add changelog. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
grafanabot
pushed a commit
that referenced
this pull request
Sep 2, 2024
#9156) * Update mimir-prometheus Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * DefaultChunkedReadLimit was moved from storage to config Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Adopt to new remote read client interface Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update otlp generate code Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * OTLP: ignore annotations for now Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Remote read Content-Type unset in tests Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Use client_golang 1.19.1 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update engine test cases from upstream Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Mark unsupported engine expressions Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Disable test that assumes the newly added `promql-delayed-name-removal` flag is enabled * Re-enable running MQE test cases against Prometheus' engine now that prometheus/prometheus#14611 has been merged * Updates due to review Add changelog. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Charles Korn <charles.korn@grafana.com> (cherry picked from commit 61634ee)
krajorama
added a commit
that referenced
this pull request
Sep 2, 2024
#9156) (#9176) * Update mimir-prometheus Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * DefaultChunkedReadLimit was moved from storage to config Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Adopt to new remote read client interface Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update otlp generate code Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * OTLP: ignore annotations for now Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Remote read Content-Type unset in tests Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Use client_golang 1.19.1 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Update engine test cases from upstream Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Mark unsupported engine expressions Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Disable test that assumes the newly added `promql-delayed-name-removal` flag is enabled * Re-enable running MQE test cases against Prometheus' engine now that prometheus/prometheus#14611 has been merged * Updates due to review Add changelog. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Charles Korn <charles.korn@grafana.com> (cherry picked from commit 61634ee) Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
julienduchesne
added a commit
that referenced
this pull request
Dec 19, 2024
Since #9156 probably, all the remote read commands return no data I added a missing error return using `timeseries.Err()` and got this error: `mimirtool: error: chunkedReader: message size exceeded the limit 0 bytes; got: 361 bytes, try --help` which lead me to find that we need to pass in `ChunkedReadLimit` on the client I set it at a default 1 MiB and configurable through a flag
4 tasks
julienduchesne
added a commit
that referenced
this pull request
Dec 19, 2024
* fix(mimirtool): Make remote-read actually return data Since #9156 probably, all the remote read commands return no data I added a missing error return using `timeseries.Err()` and got this error: `mimirtool: error: chunkedReader: message size exceeded the limit 0 bytes; got: 361 bytes, try --help` which lead me to find that we need to pass in `ChunkedReadLimit` on the client I set it at a default 1 MiB and configurable through a flag * CHANGELOG * Add other missing error * Update default read limit * Update pkg/mimirtool/commands/remote_read.go Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Update mimir-prometheus at grafana/mimir-prometheus@fdf902d
The remote read client interface has changed in prometheus/prometheus#11379
I've updated the users and also added native histogram support to backfill.
Keeps client_golang version as it has some bugs.
prometheus/client_golang#1605
prometheus/client_golang#1607