MQE: separate feature flag for binary comparison operations #9504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
approved these changes
Oct 3, 2024
grafanabot
pushed a commit
that referenced
this pull request
Oct 3, 2024
* MQE: separate feature flag for binary comparison operations * Add changelog entry (cherry picked from commit 204d110)
charleskorn
added a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces separate feature flags for comparison operations between two vectors, two scalars and between a vector and a scalar.
I've found an issue in the implementation of comparison operations for two vectors which is not trivial to fix, so it'd be nice to be able to disable just those while keeping others enabled.
Which issue(s) this PR fixes or relates to
#9398
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.