-
Notifications
You must be signed in to change notification settings - Fork 634
MQE: Histogram range vectors #8508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
charleskorn
merged 13 commits into
grafana:main
from
jhesketh:jhesketh/mqe-histogram-range-vectors
Jul 2, 2024
Merged
MQE: Histogram range vectors #8508
charleskorn
merged 13 commits into
grafana:main
from
jhesketh:jhesketh/mqe-histogram-range-vectors
Jul 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b03244
to
60554ef
Compare
charleskorn
reviewed
Jun 25, 2024
charleskorn
reviewed
Jun 28, 2024
charleskorn
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Ivaka
pushed a commit
to Ivaka/mimir
that referenced
this pull request
Jul 3, 2024
* Make ring buffer generic * Add HPoint ring buffer * Deduplicate tests * Add support for histogram range vectors * Update CHANGELOG * Fix spelling/lint * Address review feedback * Separate back out the ring buffers for performance * Fix closing histogram buffer * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add support for histogram range vector queries.
Rate and other tests coming in followup PR.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.