Skip to content

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Mar 28, 2023

What this PR does

Add a new experimental limit to enforce the size of a query is under a certain number of bytes. This limit is enforced in the query-frontend and supports queries for multiple tenants. In this case, the lowest non-zero limit is enforced.

Which issue(s) this PR fixes or relates to

Fixes #4602

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Add a new experimental limit to enforce the size of a query is under
a certain number of bytes. This limit is enforced in the query-frontend
and supports queries for multiple tenants. In this case, the lowest
non-zero limit is enforced.

Fixes #4602

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Copy link
Contributor

@Logiraptor Logiraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried to verify that the expression is not parsed before limits are applied, and I do think that's the case.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters marked this pull request as ready for review March 28, 2023 18:02
@56quarters 56quarters requested review from a team as code owners March 28, 2023 18:02
@56quarters 56quarters merged commit 117f0d6 into main Mar 28, 2023
@56quarters 56quarters deleted the 56quarters/query-length-limit branch March 28, 2023 18:22
56quarters added a commit that referenced this pull request Mar 28, 2023
Add a new experimental limit to enforce the size of a query is under
a certain number of bytes. This limit is enforced in the query-frontend
and supports queries for multiple tenants. In this case, the lowest
non-zero limit is enforced.

Fixes #4602

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this pull request Mar 28, 2023
Add a new experimental limit to enforce the size of a query is under
a certain number of bytes. This limit is enforced in the query-frontend
and supports queries for multiple tenants. In this case, the lowest
non-zero limit is enforced.

Fixes #4602

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this pull request Mar 28, 2023
Add a new experimental limit to enforce the size of a query is under
a certain number of bytes. This limit is enforced in the query-frontend
and supports queries for multiple tenants. In this case, the lowest
non-zero limit is enforced.

Fixes #4602

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters added a commit that referenced this pull request Mar 28, 2023
Add a new experimental limit to enforce the size of a query is under
a certain number of bytes. This limit is enforced in the query-frontend
and supports queries for multiple tenants. In this case, the lowest
non-zero limit is enforced.

Fixes #4602

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add limit for max query length in query-frontend
3 participants