Update chromedp/cdproto and related changes #4785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw this does reduce the k6 binary by around 4mb 🎉 |
ankur22
approved these changes
May 16, 2025
mstoykov
added a commit
that referenced
this pull request
May 20, 2025
This was missed as a thing that is needed in #4785. This is basically what easyjson was doing before. Due to some internal package structure I opted for a little copying over a little dependency. Mostly as the common package tests depend on tests/ws.
8 tasks
mstoykov
added a commit
that referenced
this pull request
May 20, 2025
This was missed as a thing that is needed in #4785. This is basically what easyjson was doing before. Due to some internal package structure I opted for a little copying over a little dependency. Mostly as the common package tests depend on tests/ws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update cdproto dependancy.
This is more involved due to them changing from easyjson to jsonv2 (experiment) which has a bunch of additional things that need changing .
Why?
Cdproto moved to it and we really need to keep updating this.
This also likely will make it possible for more optimizations with reusing jsonv2 decoder/encoders. But that will be explored later as this PR already changes so much.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)