Skip to content

Binary provisioning/configure binary cache dir #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pablochacin
Copy link
Contributor

@pablochacin pablochacin commented Apr 24, 2025

What?

Configure the directory used for caching provisioned binaries.

Note: this implementation avoids introducing a new flag to minimize the impact of the change. See #4743 for an alternative implementation.

Why?

The default value may result confusing as it makes reference to the k6provider library.

Fixes #4741

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@pablochacin pablochacin changed the base branch from master to feat/binary-provisioning April 24, 2025 18:28
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin force-pushed the binary-provisioning/configure-binary-cache-dir branch from eb534f9 to 55e946b Compare April 24, 2025 18:35
@pablochacin
Copy link
Contributor Author

Closed in favor of #4743

@mstoykov mstoykov deleted the binary-provisioning/configure-binary-cache-dir branch August 4, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant