Binary provisioning/add cache dir flag #4743
Conversation
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
cmd/state/state.go
Outdated
| if val, ok := env["K6_BINARY_CACHE"]; ok { | ||
| result.BinaryCache = val | ||
| } |
There was a problem hiding this comment.
| if val, ok := env["K6_BINARY_CACHE"]; ok { | |
| result.BinaryCache = val | |
| } |
I don't think we have to introduce this option. Go already provides a way to override the OS cache dir, if they really need it. However, even if it would be required, I would prefer if we wait for a real feature-request instead of introducing it now so we can keep the API very essential.
There was a problem hiding this comment.
I introduced it because IIRC we use it in the cloud, when we have a distroless image and UserCacheDir doesn't behave as expected.
Also, I'm not sure I want a k6 user to have to deal with a go setting ($GOCACHE) instead of a setting related to a feature they are using.
There was a problem hiding this comment.
Elaborating on my previous comment, the cache dir we are discussing is for storing the custom binaries downloaded from the build service, there's no go involved (users don't need to have it). Moreover, if in the future we support local builds, these two caches will be different
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
What?
Adds a flag for configuring the directory used to cache provisioned binaries.
Why?
The default value may result confusing as it makes reference to the
k6providerlibrary.Fixes #4741
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)