Skip to content

Conversation

Sergej-Vlasov
Copy link
Contributor

Fixed an issue where panel would not react to timeFrom and timeShift change if it those were variables

@Sergej-Vlasov Sergej-Vlasov added type/bug area/dashboard/timerange area/frontend no-changelog Skip including change in changelog/release notes labels Jan 6, 2025
@Sergej-Vlasov Sergej-Vlasov self-assigned this Jan 6, 2025
@Sergej-Vlasov Sergej-Vlasov requested a review from a team as a code owner January 6, 2025 09:55
@Sergej-Vlasov Sergej-Vlasov requested review from axelavargas and harisrozajac and removed request for a team January 6, 2025 09:55
@github-actions github-actions bot added this to the 11.5.x milestone Jan 6, 2025
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job fixing this one, I gave it a quick test and works as expected 🙌🏾 , codewise looks good to me!

relativeTime.mp4

Copy link
Contributor

@ivanortegaalba ivanortegaalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here @Sergej-Vlasov! 💯

@ivanortegaalba ivanortegaalba added add to changelog backport v11.4.x Mark PR for automatic backport to v11.4.x and removed no-changelog Skip including change in changelog/release notes labels Jan 8, 2025
@ivanortegaalba ivanortegaalba changed the title PanelTimeRange: Include timeFrom and timeShift in variable dependencies Dashboards: Panel react for timeFrom and timeShift changes using variables Jan 8, 2025
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@ivanortegaalba ivanortegaalba merged commit 8f62207 into main Jan 8, 2025
23 checks passed
@ivanortegaalba ivanortegaalba deleted the serge/react-to-interpolated-var-change-in-panel-time-range branch January 8, 2025 08:35
grafana-delivery-bot bot pushed a commit that referenced this pull request Jan 8, 2025
Sergej-Vlasov added a commit that referenced this pull request Aug 5, 2025
…ges using variables (#98659)

* Dashboards: Panels react to `timeFrom` and `timeShift` changes using variables (#98510)

(cherry picked from commit 8f62207)

* restore problematic file

* add the required test

---------

Co-authored-by: Sergej-Vlasov <37613182+Sergej-Vlasov@users.noreply.github.com>
Co-authored-by: Sergej-Vlasov <sergej.s.vlasov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants