Dashboard: Add Alert icon in library panels #107723
Merged
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarrs
reviewed
Jul 7, 2025
| @@ -50,6 +51,10 @@ export class LibraryPanelBehavior extends SceneObjectBase<LibraryPanelBehaviorSt | |||
|
|
|||
| const libPanelModel = new PanelModel(libPanel.model); | |||
|
|
|||
| // Use dashboard panel ID for data layer filtering | |||
| // const dashboardPanelId = getPanelIdForVizPanel(vizPanel); | |||
| // libPanelModel.id = dashboardPanelId; | |||
There was a problem hiding this comment.
Should these lines be commented out?
There was a problem hiding this comment.
Lol, I was testing something locally and ended up commenting out these lines, good catch!
YannickAlex07
pushed a commit
to YannickAlex07/grafana
that referenced
this pull request
Jul 11, 2025
* Use panel.id from the dashboard to filter alterts properly * add unit test * Fix linting * add fix back * fix betterer in test, use same pattern as DashboardDatasourceBehaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This fixes the issue where alert icons were not displayed in library panels when alert rules were configured for them.
When an alert rule is created for a panel, it stores the
dashboard.uidand thepanel.id. When loading a library panel, theLibraryPanelBehaviorretrieves the library panel model and replaces the current panel state in the dashboard. However, the library panel was using its original panel ID instead of the dashboard panel ID, causing a mismatch in the data layer filtering.The fix ensures that library panels use the dashboard panel ID (extracted from the
VizPanelkey) for data provider filtering, allowing alert states to be properly matched and displayed.Before
BeforeFixAlert.mp4
After
AfterFix.mp4
Which issue(s) does this PR fix?:
Fixes #107494
Special notes for your reviewer:
Please check that: