modfile: take into account that // indirect comments may not be well formatted #3
Conversation
…formatted When there is an // indirect comment next to a dependency that is not actually indirect; go mod tidy should remove it. This was not the case when the //indirect comment was badly formatted. We now check whether such a comment exists irrespective of the formatting. Fixes #45932
|
This PR (HEAD: 2ae0848) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mod/+/316569 to see it. Tip: You can toggle comments from me using the |
|
Message from Bryan C. Mills: Patch Set 1: Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/316569. |
|
This PR (HEAD: b884ee1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mod/+/316569 to see it. Tip: You can toggle comments from me using the |
|
Message from komu wairagu: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/316569. |
|
Message from Bryan C. Mills: Patch Set 2: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/316569. |
|
Message from Go Bot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/316569. |
|
Message from Go Bot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/316569. |
|
Message from Jay Conrod: Patch Set 2: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/316569. |
…formatted When there is an // indirect comment next to a dependency that is not actually indirect; go mod tidy should remove it. This was not the case when the //indirect comment was badly formatted. We now check whether such a comment exists irrespective of the formatting. Updates golang/go#45932 Change-Id: I6a7dca23059a0aca6f8f940da975a0d79f701571 GitHub-Last-Rev: b884ee1 GitHub-Pull-Request: #3 Reviewed-on: https://go-review.googlesource.com/c/mod/+/316569 Reviewed-by: Bryan C. Mills <bcmills@google.com> Trust: Bryan C. Mills <bcmills@google.com> Trust: Jay Conrod <jayconrod@google.com>
|
This PR is being closed because golang.org/cl/316569 has been merged. |
…formatted When there is an // indirect comment next to a dependency that is not actually indirect; go mod tidy should remove it. This was not the case when the //indirect comment was badly formatted. We now check whether such a comment exists irrespective of the formatting. Updates golang/go#45932 Change-Id: I6a7dca23059a0aca6f8f940da975a0d79f701571 GitHub-Last-Rev: b884ee1a3ecf821f9b6b68bf061bbe0c521c8143 GitHub-Pull-Request: golang/mod#3 Reviewed-on: https://go-review.googlesource.com/c/mod/+/316569 Reviewed-by: Bryan C. Mills <bcmills@google.com> Trust: Bryan C. Mills <bcmills@google.com> Trust: Jay Conrod <jayconrod@google.com>
When there is an // indirect comment next to a dependency that is not actually indirect;
go mod tidy should remove it.
This was not the case when the //indirect comment was badly formatted.
We now check whether such a comment exists irrespective of the formatting.
Updates golang/go#45932