-
Notifications
You must be signed in to change notification settings - Fork 350
Redis helm chart version change to 16.3.1 #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
syntxerror
merged 4 commits into
googleforgames:main
from
mridulji:redis_issues_1374_and_1418
Mar 3, 2022
Merged
Redis helm chart version change to 16.3.1 #1440
syntxerror
merged 4 commits into
googleforgames:main
from
mridulji:redis_issues_1374_and_1418
Mar 3, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
939c0f7
to
fcc8673
Compare
fcc8673
to
a065aec
Compare
syntxerror
reviewed
Mar 3, 2022
syntxerror
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job
bturk-rh
added a commit
to RallyHereInteractive/open-match
that referenced
this pull request
Apr 8, 2022
Based on the PR that open match merged in the last month or so. See Also: PLAT-3377 googleforgames#1440
bturk-rh
added a commit
to RallyHereInteractive/open-match
that referenced
this pull request
Apr 8, 2022
Based on the PR that open match merged in the last month or so. See Also: PLAT-3377 googleforgames#1440 (cherry picked from commit f86da57)
bturk-rh
added a commit
to RallyHereInteractive/open-match
that referenced
this pull request
Apr 8, 2022
Updating open match to the latest redis chart Based on the PR that open match merged in the last month or so. See Also: PLAT-3377 googleforgames#1440
bturk-rh
added a commit
to RallyHereInteractive/open-match
that referenced
this pull request
Apr 11, 2022
… when porting googleforgames#1440 over. See Also: PLAT-3377 googleforgames#1440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking api change
Breaking API change that may require migration for existing customers to update to new version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Currently as we are seeing few github issues which talks about problems regarding data sync amongst the redis pods are as follows:
One solution to counter above issues is upgrading the redis helm chart used in OM

And doing so requires the machine type

n1-standard-4
on GKE cluster to provide the sufficient allocatable cpu and keeping the pre-existing values of resource request as it is.Minor changes done to align with new redis chart version are:
Lastly, this PR updates the helm version which would be helpful in working with latest dependencies.
Which issue(s) this PR fixes:
Closes #1374
Closes #1418
Closes #1439
Special notes for your reviewer:
folks who may be currently in the process of trying out Open Match would need to use cluster with machine type
n1-standard-4
to tryout the changes in this PR