Skip to content

Conversation

mridulji
Copy link
Contributor

What this PR does / Why we need it:
Currently as we are seeing few github issues which talks about problems regarding data sync amongst the redis pods are as follows:

  1. There are multiple redis masters in v1.2.0-rc.1 #1374
  2. Tutorial: mm101-tutorial-frontend got "Failed to Get Ticket" errors #1418

One solution to counter above issues is upgrading the redis helm chart used in OM
image

And doing so requires the machine type n1-standard-4 on GKE cluster to provide the sufficient allocatable cpu and keeping the pre-existing values of resource request as it is.
image

Minor changes done to align with new redis chart version are:

  • slave --> replica
  • usePassword: --> auth: enabled:
  • redis.fullname --> common.names.fullname

Lastly, this PR updates the helm version which would be helpful in working with latest dependencies.

Which issue(s) this PR fixes:

Closes #1374
Closes #1418
Closes #1439

Special notes for your reviewer:

folks who may be currently in the process of trying out Open Match would need to use cluster with machine type n1-standard-4 to tryout the changes in this PR

@mridulji mridulji force-pushed the redis_issues_1374_and_1418 branch from fcc8673 to a065aec Compare February 18, 2022 06:41
Copy link
Contributor

@syntxerror syntxerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job

@syntxerror syntxerror merged commit b6e5114 into googleforgames:main Mar 3, 2022
@mridulji mridulji added this to the v1.4.0 milestone Mar 14, 2022
@mridulji mridulji added the breaking api change Breaking API change that may require migration for existing customers to update to new version. label Mar 14, 2022
bturk-rh added a commit to RallyHereInteractive/open-match that referenced this pull request Apr 8, 2022
Based on the PR that open match merged in the last month or so.

See Also:
PLAT-3377
googleforgames#1440
bturk-rh added a commit to RallyHereInteractive/open-match that referenced this pull request Apr 8, 2022
Based on the PR that open match merged in the last month or so.

See Also:
PLAT-3377
googleforgames#1440

(cherry picked from commit f86da57)
bturk-rh added a commit to RallyHereInteractive/open-match that referenced this pull request Apr 8, 2022
Updating open match to the latest redis chart

Based on the PR that open match merged in the last month or so.

See Also:
PLAT-3377
googleforgames#1440
bturk-rh added a commit to RallyHereInteractive/open-match that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking api change Breaking API change that may require migration for existing customers to update to new version.
Projects
None yet
2 participants