Skip to content

feat: Manifest.createRelease to return PR numbers #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

feat: Manifest.createRelease to return PR numbers #2491

merged 1 commit into from
Feb 27, 2025

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 27, 2025 •
edited
Loading

This pull request gives the caller of the Manifest.createRelease with the pull request number. This is for the Release Please bot's new capability to tag a commit with the Release Please pull request numbers. https://github.com/googleapis/repo-automation-bots/blob/main/packages/release-please/src/release-please.ts#L386 will receive the pull request number. The CreatedRelease interface extends GitHubRelease, which has commit SHA for the release.

b/b/394646919

@gemini-code-assist Gemini Code Assist
Copy link

Warning

You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again!

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 27, 2025
@suztomo
Copy link
Member Author

suztomo commented Feb 27, 2025

The build-action check is failing. I will need to update the tests there: https://github.com/googleapis/release-please-action/blob/main/test/release-please.ts

Error: [tsl] ERROR in /home/runner/work/release-please/release-please/test/release-please.ts(308,9)
      TS2741: Property 'prNumber' is missing in type '{ id: number; name: string; tagName: string; sha: string; notes: string; url: string; draft: false; uploadUrl: string; path: string; version: string; major: number; minor: number; patch: number; }' but required in type 'CreatedRelease'.
[tsl] ERROR in /home/runner/work/release-please/release-please/test/release-please.ts(363,9)
      TS2741: Property 'prNumber' is missing in type '{ id: number; name: string; tagName: string; sha: string; notes: string; url: string; draft: false; uploadUrl: string; path: string; version: string; major: number; minor: number; patch: number; }' but required in type 'CreatedRelease'.
[tsl] ERROR in /home/runner/work/release-please/release-please/test/release-please.ts(378,9)
      TS2741: Property 'prNumber' is missing in type '{ id: number; name: string; tagName: string; sha: string; notes: string; url: string; draft: false; uploadUrl: string; path: string; version: string; major: number; minor: number; patch: number; }' but required in type 'CreatedRelease'.

@suztomo suztomo marked this pull request as ready for review February 27, 2025 04:08
@suztomo suztomo requested review from a team as code owners February 27, 2025 04:08
@suztomo suztomo requested a review from chingor13 February 27, 2025 04:08
@suztomo suztomo added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 0f07691 Feb 27, 2025
13 of 14 checks passed
@suztomo suztomo deleted the pr-number branch February 27, 2025 17:06
@release-please release-please bot mentioned this pull request Feb 27, 2025
Merged
@meltsufin meltsufin mentioned this pull request Mar 8, 2025
Closed
soulsam480 pushed a commit to revenuehero/release-please that referenced this pull request Mar 14, 2025
@suztomo @soulsam480
feat: Manifest.createRelease to return PR numbers (googleapis#2491)
f44a58c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @chingor13