tracing: update OpenTelemetry dependencies from 2021 to 2024 #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149484b to
c906c09
Compare
|
Kindly cc-ing you @harshachinta. /cc @willpoint |
c906c09 to
3389806
Compare
ExhibitWith this change and the example/trace.py being ran, we get back these traces |
ffbc624 to
4092436
Compare
685f2c8 to
d573f04
Compare
|
@harshachinta kindly please see my replies to your review comments. Thank you! |
4c1d4bc to
9ff8017
Compare
harshachinta
approved these changes
Sep 17, 2024
22f37e6 to
04db2a7
Compare
04db2a7 to
2645ab5
Compare
|
@harshachinta all updates made, kindly help me kick off the Kokoro bots, and thank you for the reviews too! |
2 tasks
69d9519 to
250f687
Compare
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
250f687 to
c5e2f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.
While here also brought in modern span attributes:
Also added a modernized example and updated the docs.
Updates #1170
Fixes #1173
Built from PR #1172