Skip to content

chore: add x_goog_spanner_request_id as attribute to spans #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

chore: add x_goog_spanner_request_id as attribute to spans #2275

merged 1 commit into from
Apr 11, 2025

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Apr 7, 2025

This change adds the x-goog-spanner-request-id value that is sent as a gRPC header, but as a span attribute with the key x_goog_spanner_request_id to aid in better debugging and correlation.

Updates #2200

@odeke-em odeke-em requested review from a team as code owners April 7, 2025 18:56
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Apr 7, 2025
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2025
@odeke-em odeke-em force-pushed the x-goog-spanner-request-id-add-as-attribute-to-spans branch from 4e49d0e to b3df112 Compare April 8, 2025 17:45
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 8, 2025
@odeke-em odeke-em force-pushed the x-goog-spanner-request-id-add-as-attribute-to-spans branch from b3df112 to 9cd2de5 Compare April 8, 2025 18:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 8, 2025
@odeke-em
chore: add x_goog_spanner_request_id as attribute to spans
9f35bd3 
This change adds the x-goog-spanner-request-id value that is
sent as a gRPC header, but as a span attribute with the
key `x_goog_spanner_request_id` to aid in better debugging
and correlation.

Updates googleapis#2200
@odeke-em odeke-em force-pushed the x-goog-spanner-request-id-add-as-attribute-to-spans branch from 9cd2de5 to 9f35bd3 Compare April 8, 2025 18:53
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2025
@olavloite olavloite added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 10, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 10, 2025
@olavloite olavloite merged commit 58a53cd into googleapis:main Apr 11, 2025
17 of 18 checks passed
@odeke-em odeke-em deleted the x-goog-spanner-request-id-add-as-attribute-to-spans branch April 11, 2025 07:03
alkatrivedi pushed a commit that referenced this pull request Apr 14, 2025
@odeke-em @alkatrivedi
chore: add x_goog_spanner_request_id as attribute to spans (#2275)
60ab6e7 
This change adds the x-goog-spanner-request-id value that is
sent as a gRPC header, but as a span attribute with the
key `x_goog_spanner_request_id` to aid in better debugging
and correlation.

Updates #2200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odeke-em @olavloite @yoshi-kokoro